chore: add migration service

Author: Brian Cummings

.github/workflows/main_pathfinderhonormanager.yml

@@ -96,14 +96,6 @@ jobs:
           name: migration-script
           path: PathfinderHonorManager/migration.sql
 
-      - name: Apply EF Migrations (Safe - Additive Only)
-        run: |
-          dotnet ef database update --connection "$PROD_CONNECTION_STRING"
-        working-directory: ./PathfinderHonorManager
-        env:
-          PROD_CONNECTION_STRING: ${{ secrets.PRODCONNECTIONSTRING }}
-          ConnectionStrings__PathfinderCS: ${{ secrets.PRODCONNECTIONSTRING }}
-      
       - name: dotnet publish
         run: dotnet publish -c Release -o ${{env.DOTNET_ROOT}}/myapp
 

PathfinderHonorManager/Healthcheck/MigrationHealthCheck.cs

@@ -23,19 +23,27 @@ public async Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context
             try
             {
                 var pendingMigrations = await _context.Database.GetPendingMigrationsAsync(cancellationToken);
+                var appliedMigrations = await _context.Database.GetAppliedMigrationsAsync(cancellationToken);
 
                 if (pendingMigrations.Any())
                 {
                     return HealthCheckResult.Degraded(
-                        "Database has pending migrations",
+                        "Database has pending migrations - migrations should be applied at startup",
                         data: new Dictionary<string, object>
                         {
                             ["PendingMigrations"] = pendingMigrations.ToArray(),
-                            ["PendingCount"] = pendingMigrations.Count()
+                            ["PendingCount"] = pendingMigrations.Count(),
+                            ["AppliedCount"] = appliedMigrations.Count()
                         });
                 }
 
-                return HealthCheckResult.Healthy("Database schema is up-to-date");
+                return HealthCheckResult.Healthy(
+                    "Database schema is up-to-date",
+                    data: new Dictionary<string, object>
+                    {
+                        ["AppliedMigrations"] = appliedMigrations.Count(),
+                        ["LastMigration"] = appliedMigrations.LastOrDefault() ?? "None"
+                    });
             }
             catch (Exception ex)
             {

PathfinderHonorManager/Program.cs

@@ -5,6 +5,7 @@
 using Microsoft.Extensions.Logging.AzureAppServices;
 using Microsoft.Extensions.Configuration;
 using System.Diagnostics.CodeAnalysis;
+using PathfinderHonorManager.Service;
 
 namespace PathfinderHonorManager
 {

PathfinderHonorManager/Service/MigrationService.cs

@@ -0,0 +1,64 @@
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
+using PathfinderHonorManager.DataAccess;
+using System;
+using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace PathfinderHonorManager.Service
+{
+    public class MigrationService : IHostedService
+    {
+        private readonly IServiceProvider _serviceProvider;
+        private readonly ILogger<MigrationService> _logger;
+
+        public MigrationService(IServiceProvider serviceProvider, ILogger<MigrationService> logger)
+        {
+            _serviceProvider = serviceProvider;
+            _logger = logger;
+        }
+
+        public async Task StartAsync(CancellationToken cancellationToken)
+        {
+            _logger.LogInformation("Starting database migration check...");
+
+            using var scope = _serviceProvider.CreateScope();
+            var context = scope.ServiceProvider.GetRequiredService<PathfinderContext>();
+
+            try
+            {
+                var pendingMigrations = await context.Database.GetPendingMigrationsAsync(cancellationToken);
+                
+                if (pendingMigrations.Any())
+                {
+                    _logger.LogInformation("Found {Count} pending migrations. Applying...", pendingMigrations.Count());
+                    
+                    foreach (var migration in pendingMigrations)
+                    {
+                        _logger.LogInformation("Pending migration: {Migration}", migration);
+                    }
+
+                    await context.Database.MigrateAsync(cancellationToken);
+                    _logger.LogInformation("Database migrations completed successfully");
+                }
+                else
+                {
+                    _logger.LogInformation("Database is up-to-date, no migrations needed");
+                }
+
+                var appliedMigrations = await context.Database.GetAppliedMigrationsAsync(cancellationToken);
+                _logger.LogInformation("Total applied migrations: {Count}", appliedMigrations.Count());
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "Failed to apply database migrations. Application startup will be aborted.");
+                throw new InvalidOperationException("Database migration failed during application startup. See inner exception for details.", ex);
+            }
+        }
+
+        public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
+    }
+}

PathfinderHonorManager/Startup.cs

@@ -135,7 +135,14 @@ public void ConfigureServices(IServiceCollection services)
             services
                 .AddDbContext<PathfinderContext>(options =>
                     options.UseNpgsql(Configuration.GetConnectionString("PathfinderCS"), 
-                        npgsqlOptions => npgsqlOptions.CommandTimeout(30)));
+                        npgsqlOptions => 
+                        {
+                            npgsqlOptions.CommandTimeout(60);
+                            npgsqlOptions.EnableRetryOnFailure(
+                                maxRetryCount: 3,
+                                maxRetryDelay: TimeSpan.FromSeconds(10),
+                                errorCodesToAdd: null);
+                        }));
             services
                 .AddAutoMapper(typeof(AutoMapperConfig));
             services
@@ -145,6 +152,8 @@ public void ConfigureServices(IServiceCollection services)
                 .AddScoped<IClubService, ClubService>()
                 .AddScoped<IAchievementService, AchievementService>()
                 .AddScoped<IPathfinderAchievementService, PathfinderAchievementService>();
+            
+            services.AddHostedService<MigrationService>();
             services
                 .AddFluentValidationAutoValidation()
                 .AddFluentValidationClientsideAdapters()