tech(core dom): toNodeArray - filter for instances of Node only.

Author: thet

src/core/dom.js

@@ -37,17 +37,18 @@ const document_ready = (fn) => {
 /**
  * Return an array of DOM nodes.
  *
- * @param {Node|NodeList|jQuery} nodes - The DOM node to start the search from.
+ * @param {Node|NodeList|jQuery} nodes - The object which whould be returned as array.
  *
  * @returns {Array} - An array of DOM nodes.
  */
 const toNodeArray = (nodes) => {
-    if (nodes.jquery || nodes instanceof NodeList) {
-        // jQuery or document.querySelectorAll
+    if (nodes?.jquery || nodes instanceof NodeList) {
         nodes = [...nodes];
     } else if (nodes instanceof Array === false) {
         nodes = [nodes];
     }
+    // Filter for DOM nodes only.
+    nodes = nodes.filter(node => node instanceof Node)
     return nodes;
 };
 

src/core/dom.test.js

@@ -101,10 +101,17 @@ describe("core.dom tests", () => {
             expect(testee.length).toBe(2);
 
             const ret = dom.toNodeArray(testee);
+
             expect(ret.jquery).toBeFalsy();
             expect(ret.length).toBe(2);
+
             expect(ret[0]).toBe(el1);
+            expect(ret[0].jquery).toBeFalsy();
+            expect(ret[0] instanceof Node).toBe(true);
+
             expect(ret[1]).toBe(el2);
+            expect(ret[1].jquery).toBeFalsy();
+            expect(ret[1] instanceof Node).toBe(true);
 
             done();
         });
@@ -139,6 +146,25 @@ describe("core.dom tests", () => {
 
             done();
         });
+
+        it("returns an empty array, if nothing was passed", (done) => {
+            const ret = dom.toNodeArray();
+            expect(ret.length).toBe(0);
+            expect(ret instanceof Array).toBe(true);
+
+            done();
+        });
+
+        it("returns only DOM Nodes", (done) => {
+            const el = document.body;
+            const txt = document.createTextNode("okay");
+            const ret = dom.toNodeArray([1, false, txt, "okay", el], false);
+            expect(ret.length).toBe(2);
+            expect(ret[0]).toBe(txt);
+            expect(ret[1]).toBe(el);
+
+            done();
+        });
     });
 
     describe("querySelectorAllAndMe tests", () => {