maint(pat-inject): Test automatic title insertion in history record mode.

Author: thet

src/pat/inject/inject.js

@@ -454,7 +454,7 @@ const inject = {
         return $target;
     },
 
-    _performInjection(target, $el, $source, cfg, trigger, title) {
+    _performInjection(target, $el, $source, cfg, trigger, $title) {
         /* Called after the XHR has succeeded and we have a new $source
          * element to inject.
          */
@@ -485,13 +485,13 @@ const inject = {
         // Now the injection actually happens.
         if (this._inject(trigger, source_nodes, target, cfg)) {
             // Update history
-            this._update_history(cfg, trigger, title);
+            this._update_history(cfg, trigger, $title);
             // Post-injection
             this._afterInjection($el, cfg.$created_target || $(source_nodes), cfg);
         }
     },
 
-    _update_history(cfg, trigger, title) {
+    _update_history(cfg, trigger, $title) {
         // History support. if subform is submitted, append form params
         if (cfg.history !== "record" || !history?.pushState) {
             return;
@@ -503,10 +503,10 @@ const inject = {
         }
         history.pushState({ url: url }, "", url);
         // Also inject title element if we have one
-        if (title) {
+        if ($title.length) {
             const title_el = document.querySelector("title");
             if (title_el) {
-                this._inject(trigger, [title], title_el, {
+                this._inject(trigger, $title, title_el, {
                     action: "element",
                 });
             }
@@ -585,14 +585,14 @@ const inject = {
         ]);
         /* pick the title source for dedicated handling later
           Title - if present - is always appended at the end. */
-        let title;
+        let $title;
         if (
             sources$ &&
             sources$[sources$.length - 1] &&
             sources$[sources$.length - 1][0] &&
             sources$[sources$.length - 1][0].nodeName === "TITLE"
         ) {
-            title = sources$[sources$.length - 1];
+            $title = sources$[sources$.length - 1];
         }
         cfgs.forEach((cfg, idx1) => {
             const perform_inject = () => {
@@ -604,7 +604,7 @@ const inject = {
                             sources$[idx1],
                             cfg,
                             ev.target,
-                            title
+                            $title
                         );
                     }
                 }
@@ -967,8 +967,11 @@ const inject = {
         let clean_html = html
             .replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, "")
             .replace(/<head\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/head>/gi, "")
+            .replace(/<html([^>]*?)>/gi, "")
+            .replace(/<\/html([^>]*?)>/gi, "")
             .replace(/<body([^>]*?)>/gi, '<div id="__original_body">')
             .replace(/<\/body([^>]*?)>/gi, "</div>");
+
         if (title && title.length == 2) {
             clean_html = title[0] + clean_html;
         }
@@ -1109,7 +1112,8 @@ const inject = {
             sources(cfgs, data) {
                 const sources = cfgs.map((cfg) => cfg.source);
                 sources.push("title");
-                return this._sourcesFromHtml(data, cfgs[0].url, sources);
+                const result = this._sourcesFromHtml(data, cfgs[0].url, sources);
+                return result;
             },
         },
     },

src/pat/inject/inject.test.js

@@ -1557,9 +1557,7 @@ describe("pat-inject", function () {
 
                         expect(catched).toBe(true);
                         expect(pattern.execute).toHaveBeenCalled();
-
                     });
-
                 });
             });
         });
@@ -1652,6 +1650,98 @@ describe("pat-inject", function () {
             });
         });
 
+        describe("9.4 - injecton of the title element.", function () {
+            let spy_ajax;
+
+            beforeEach(function () {
+                spy_ajax = jest.spyOn($, "ajax").mockImplementation(() => deferred);
+            });
+
+            afterEach(function () {
+                spy_ajax.mockRestore();
+            });
+
+            it("9.4.1 - Injects a title element with history:record", async function () {
+                document.head.innerHTML = `
+                    <title>test</title>
+                `;
+                document.body.innerHTML = `
+                    <a class="pat-inject"
+                       href="test.html"
+                       data-pat-inject="
+                        source: body;
+                        target: body;
+                        history: record;
+                    ">link</a>
+                `;
+
+                answer(`
+                    <html>
+                        <head>
+                            <title>hello</title>
+                        </head>
+                        <body>
+                            OK
+                        </body>
+                    </html>
+                `);
+
+                const inject = document.querySelector(".pat-inject");
+
+                pattern.init($(inject));
+                await utils.timeout(1); // wait a tick for async to settle.
+
+                inject.click();
+
+                await utils.timeout(1); // wait a tick for async to settle.
+
+                expect(document.body.textContent.trim()).toBe("OK");
+
+                const title = document.head.querySelector("title");
+                expect(title).toBeTruthy();
+                expect(title.textContent.trim()).toBe("hello");
+            });
+
+            it("9.4.2 - Does not inject a title element without history:record", async function () {
+                document.head.innerHTML = `
+                    <title>test</title>
+                `;
+                document.body.innerHTML = `
+                    <a class="pat-inject"
+                       href="test.html"
+                       data-pat-inject="
+                        source: body;
+                        target: body;
+                    ">link</a>
+                `;
+
+                answer(`
+                    <html>
+                        <head>
+                            <title>hello</title>
+                        </head>
+                        <body>
+                            OK
+                        </body>
+                    </html>
+                `);
+
+                const inject = document.querySelector(".pat-inject");
+
+                pattern.init($(inject));
+                await utils.timeout(1); // wait a tick for async to settle.
+
+                inject.click();
+
+                await utils.timeout(1); // wait a tick for async to settle.
+
+                expect(document.body.textContent.trim()).toBe("OK");
+
+                const title = document.head.querySelector("title");
+                expect(title).toBeTruthy();
+                expect(title.textContent.trim()).toBe("test"); // Old title
+            });
+        });
     });
 
     describe("10 - Error handling", () => {