Skip to content

Commit 3a163fa

Browse files
kim-emclaude
authored andcommitted
Fix simpNF linter warnings
This PR fixes 8 simpNF linter warnings across 3 files: **BumpFunctor.lean:** - `Bump_apply_of_mem` - Removed @[simp] (simp can prove via Bump_obj + ite_true) - `Bump_apply_of_not_mem` - Removed @[simp] (simp can prove via Bump_obj + ite_false) **DirectSumDecompositionDual.lean:** - `RefinmentMapFunctorial` - Removed @[simp] (argument J cannot be inferred) **EndoRingIsLocal.lean:** - `ZeroEndAppIsZero` - Changed LHS to simplified form `fun X => 0` - `NegApp` - Changed LHS from `(-θ).app X` to `(OppEndo C R F θ).app X` - `NegAppModule` - Same LHS change as NegApp - `CompIsComp` - Removed @[simp] (simp can prove via MulDef + NatTrans.comp_app) - `PowEqCompRight` - Changed LHS from `θ^(n+1)` to `θ ≫ (θ^n)` (already simplified by PowEqCompLeft) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 25c08c3 commit 3a163fa

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

PersistentDecomp/BumpFunctor.lean

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,10 @@ We can also show functoriality in the choice of the element `e`.-/
8888

8989
section API
9090

91-
@[simp]
9291
lemma Bump_apply_of_mem {x : C} (hx : x ∈ S) :
9392
(Bump e hz hS).obj x = e := by
9493
simp only [Bump_obj, hx, ↓reduceIte]
9594

96-
@[simp]
9795
lemma Bump_apply_of_not_mem {x : C} (hx : x ∉ S) :
9896
(Bump e hz hS).obj x = z := by
9997
simp only [Bump_obj, hx, ↓reduceIte]

PersistentDecomp/DirectSumDecompositionDual.lean

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ lemma SendsToUniqueGE (I : DirectSumDecomposition M) (J : DirectSumDecomposition
200200
let B : I := (RefinementMap I J h N)
201201
rw [UniqueGE I J N A B (⟨h_le, RefinementMapLE I J h N⟩)]
202202

203-
@[simp]
204203
lemma RefinmentMapFunctorial (I : DirectSumDecomposition M) (J : DirectSumDecomposition M)
205204
(K : DirectSumDecomposition M) (hij : IsRefinement J I) (hjk : IsRefinement K J)
206205
(hik : IsRefinement K I) (N : K) :

PersistentDecomp/EndoRingIsLocal.lean

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ lemma OneDef : (1 : EndRing C R F) = (𝟙 F) := by
221221
rfl
222222

223223
@[simp]
224-
lemma ZeroEndAppIsZero : (ZeroEndomorphism C R F).app = 0 := by
224+
lemma ZeroEndAppIsZero : (fun X => 0 : ∀ X : C, F.obj X →ₗ[R] F.obj X) = 0 := by
225225
rfl
226226

227227
@[simp]
@@ -247,19 +247,19 @@ lemma NegDef (θ : EndRing C R F) : -θ = OppEndo C R F θ := by
247247
rfl
248248

249249
@[simp]
250-
lemma NegApp (θ : EndRing C R F) (X : C) : (-θ).app X = - (θ.app X) := by
250+
lemma NegApp (θ : EndRing C R F) (X : C) : (OppEndo C R F θ).app X = - (θ.app X) := by
251251
rfl
252252

253253
@[simp]
254-
lemma NegAppModule (θ : EndRing C R F) (X : C) (x : F.obj X) :((-θ).app X) x = - (θ.app X x) := by
254+
lemma NegAppModule (θ : EndRing C R F) (X : C) (x : F.obj X) :
255+
((OppEndo C R F θ).app X) x = - (θ.app X x) := by
255256
rfl
256257

257258
@[simp]
258259
lemma MulDef (e : EndRing C R F) (f : EndRing C R F):
259260
(e * f) = f ≫ e := by
260261
rfl
261262

262-
@[simp]
263263
lemma CompIsComp (e : EndRing C R F) (f : EndRing C R F) (X : C) :
264264
(e * f).app X = f.app X ≫ e.app X := by
265265
rfl
@@ -289,8 +289,8 @@ lemma PowEqCompLeft (θ : EndRing C R F) (n : ℕ) : θ^(n+1) = θ ≫ (θ^n) :=
289289
rfl
290290

291291
@[simp]
292-
lemma PowEqCompRight (θ : EndRing C R F) (n : ℕ) : θ^(n+1) = (θ^n) ≫ θ := by
293-
rw [←MulDef]
292+
lemma PowEqCompRight (θ : EndRing C R F) (n : ℕ) : θ ≫ (θ^n) = (θ^n) ≫ θ := by
293+
rw [←PowEqCompLeft, ←MulDef]
294294
have h : n = (n+1)-1 := by simp
295295
nth_rewrite 2 [h]
296296
rw [mul_pow_sub_one]

0 commit comments

Comments
 (0)