Improve PHP 8.4+ support by avoiding implicitly nullable types

Author: PaulRotmann

composer.json

@@ -12,7 +12,7 @@
     ],
     "require": {
         "php": ">=5.3.6",
-        "knplabs/packagist-api": "^1.0",
+        "knplabs/packagist-api": "^1.5",
         "symfony/console": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5",
         "symfony/finder": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5",
         "symfony/process": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5"

src/Command/Build.php

@@ -13,7 +13,7 @@ class Build extends Command
     /** @var Packager */
     private $packager;
 
-    public function __construct(Packager $packager = null)
+    public function __construct($packager = null)
     {
         parent::__construct();
 

src/Command/Install.php

@@ -18,7 +18,7 @@ class Install extends Command
     /** @var bool */
     private $isWindows;
 
-    public function __construct(Packager $packager = null, $isWindows = null)
+    public function __construct($packager = null, $isWindows = null)
     {
         if ($packager === null) {
             $packager = new Packager();

src/Command/Search.php

@@ -27,7 +27,7 @@ class Search extends Command
     /** @var bool */
     private $isWindows;
 
-    public function __construct(Packager $packager = null, Client $packagist = null, $isWindows = null)
+    public function __construct($packager = null, $packagist = null, $isWindows = null)
     {
         if ($packager === null) {
             $packager = new Packager();
@@ -77,13 +77,24 @@ protected function select(InputInterface $input, OutputInterface $output, $label
         }
 
         $question = new ChoiceQuestion($label, $select);
-        $index = array_search($helper->ask($input, $output, $question), $select);
+        $selected = $helper->ask($input, $output, $question);
+        $index = array_search($selected, $select, true);
+
+        // Check if the index is valid (not false)
+        if ($index === false) {
+            return null;
+        }
 
         if ($index === 0) {
             return null;
         }
 
         $indices = array_keys($choices);
+        // Verify index is in range before accessing
+        if (!isset($indices[$index - 1])) {
+            return null;
+        }
+
         return $indices[$index - 1];
     }