Skip to content

Commit 5c979f1

Browse files
committed
Run tests on PHP 8.4 and update test environment
1 parent d9f16d2 commit 5c979f1

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ on:
77
jobs:
88
PHPUnit:
99
name: PHPUnit (PHP ${{ matrix.php }})
10-
runs-on: ubuntu-22.04
10+
runs-on: ubuntu-24.04
1111
strategy:
1212
matrix:
1313
php:
14+
- 8.4
1415
- 8.3
1516
- 8.2
1617
- 8.1
@@ -29,7 +30,7 @@ jobs:
2930
- uses: shivammathur/setup-php@v2
3031
with:
3132
php-version: ${{ matrix.php }}
32-
coverage: xdebug
33+
coverage: ${{ matrix.php < 8.0 && 'xdebug' || 'pcov' }}
3334
ini-file: development
3435
- run: composer install
3536
- run: docker pull busybox:latest

tests/FunctionalClientTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ public function testCreateConnectDisconnectAndRemoveNetwork()
479479
$ret = \React\Async\await($promise);
480480

481481
// expects "create", "disconnect", "destroy" events ("connect" will be skipped because we don't start the container)
482-
$this->assertCount(3, $ret);
482+
$this->assertCount(2, $ret);
483483
$this->assertEquals('create', $ret[0]['Action']);
484484
$this->assertEquals('disconnect', $ret[1]['Action']);
485485
$this->assertEquals('destroy', $ret[2]['Action']);

0 commit comments

Comments
 (0)