Run tests on PHP 8.4 and update test environment

Author: PaulRotmann

.github/workflows/ci.yml

@@ -7,10 +7,11 @@ on:
 jobs:
   PHPUnit:
     name: PHPUnit (PHP ${{ matrix.php }})
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       matrix:
         php:
+          - 8.4
           - 8.3
           - 8.2
           - 8.1
@@ -38,7 +39,7 @@ jobs:
 
   PHPUnit-hhvm:
     name: PHPUnit (HHVM)
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     continue-on-error: true
     steps:
       - uses: actions/checkout@v4

src/Client.php

@@ -28,7 +28,7 @@ class Client
      * @param ?LoopInterface $loop
      * @param ?MulticastFactory $multicast
      */
-    public function __construct(LoopInterface $loop = null, MulticastFactory $multicast = null)
+    public function __construct(?LoopInterface $loop = null, ?MulticastFactory $multicast = null)
     {
         $this->loop = $loop ?: Loop::get();
         $this->multicast = $multicast ?: new MulticastFactory($this->loop);
@@ -46,29 +46,36 @@ public function search($searchTarget = 'ssdp:all', $mx = 2)
         $socket = $this->multicast->createSender();
         // TODO: The TTL for the IP packet SHOULD default to 2 and SHOULD be configurable.
 
-        $timer = $this->loop->addTimer($mx, function() use ($socket, &$deferred) {
-            $deferred->resolve();
-            $socket->close();
-        });
+        // Use a variable to track the timer outside closures
+        $timer = null;
 
+        // Create the deferred with the canceller function
         $loop = $this->loop;
         $deferred = new Deferred(function () use ($socket, &$timer, $loop) {
             // canceling resulting promise cancels timer and closes socket
-            $loop->cancelTimer($timer);
+            if ($timer !== null) {
+                $loop->cancelTimer($timer);
+            }
             $socket->close();
             throw new RuntimeException('Cancelled');
         });
 
-        $that = $this;
-        $socket->on('message', function ($data, $remote) use ($deferred, $that) {
-            $message = $that->parseMessage($data, $remote);
+            // Now set up the timer with reference to our deferred
+            $timer = $this->loop->addTimer($mx, function() use ($socket, $deferred) {
+                $deferred->resolve();
+                $socket->close();
+            });
 
-            $deferred->progress($message);
-        });
+                $that = $this;
+                $socket->on('message', function ($data, $remote) use ($deferred, $that) {
+                    $message = $that->parseMessage($data, $remote);
+
+                    $deferred->progress($message);
+                });
 
-        $socket->send($data, self::ADDRESS);
+                    $socket->send($data, self::ADDRESS);
 
-        return $deferred->promise();
+                    return $deferred->promise();
     }
 
     /** @internal */