Skip to content

Commit 1236bbb

Browse files
committed
Change 'virtual' to 'override' where appropriate
This makes it clearer which functions override.
1 parent 058d280 commit 1236bbb

File tree

26 files changed

+189
-189
lines changed

26 files changed

+189
-189
lines changed

teensy/CrashReport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
class CrashReportClass: public Printable {
77
public:
8-
virtual size_t printTo(Print& p) const;
8+
size_t printTo(Print& p) const override;
99
void clear();
1010
operator bool();
1111
};

teensy/HardwareSerial.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ class HardwareSerial : public Stream
1313
void _begin(uint16_t baud_count, uint8_t pin);
1414
void end(void);
1515
void transmitterEnable(uint8_t pin);
16-
virtual int available(void);
17-
virtual int peek(void);
18-
virtual int read(void);
19-
virtual void flush(void);
20-
int availableForWrite(void);
16+
int available(void) override;
17+
int peek(void) override;
18+
int read(void) override;
19+
void flush(void) override;
20+
int availableForWrite(void) override;
2121
void clear(void);
2222
#if ARDUINO >= 100
23-
virtual size_t write(uint8_t);
23+
size_t write(uint8_t) override;
2424
#else
2525
virtual void write(uint8_t);
2626
#endif

teensy/IPAddress.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class IPAddress : public Printable {
7070
IPAddress& operator=(const uint8_t *address);
7171
IPAddress& operator=(uint32_t address);
7272

73-
virtual size_t printTo(Print& p) const;
73+
size_t printTo(Print& p) const override;
7474

7575
friend class EthernetClass;
7676
friend class UDP;

teensy3/CrashReport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
class CrashReportClass: public Printable {
77
public:
8-
virtual size_t printTo(Print& p) const;
8+
size_t printTo(Print& p) const override;
99
void clear();
1010
operator bool();
1111
void breadcrumb(unsigned int num, unsigned int value) { }

teensy3/FS.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class File final : public Stream {
167167
}
168168

169169
// override print version
170-
virtual size_t write(const uint8_t *buf, size_t size) {
170+
size_t write(const uint8_t *buf, size_t size) override {
171171
return (f) ? f->write((void*)buf, size) : 0;
172172
}
173173

teensy3/HardwareSerial.h

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -292,21 +292,21 @@ class HardwareSerial : public Stream
292292
virtual void setTX(uint8_t pin, bool opendrain=false) { serial_set_tx(pin, opendrain); }
293293
virtual bool attachRts(uint8_t pin) { return serial_set_rts(pin); }
294294
virtual bool attachCts(uint8_t pin) { return serial_set_cts(pin); }
295-
virtual int available(void) { return serial_available(); }
296-
virtual int peek(void) { return serial_peek(); }
297-
virtual int read(void) { return serial_getchar(); }
298-
virtual void flush(void) { serial_flush(); }
295+
int available(void) override { return serial_available(); }
296+
int peek(void) override { return serial_peek(); }
297+
int read(void) override { return serial_getchar(); }
298+
void flush(void) override { serial_flush(); }
299299
virtual void clear(void) { serial_clear(); }
300-
virtual int availableForWrite(void) { return serial_write_buffer_free(); }
300+
int availableForWrite(void) override { return serial_write_buffer_free(); }
301301
virtual void addMemoryForRead(void *buffer, size_t length) {serial_add_memory_for_read(buffer, length);}
302302
virtual void addMemoryForWrite(void *buffer, size_t length){serial_add_memory_for_write(buffer, length);}
303303
using Print::write;
304-
virtual size_t write(uint8_t c) { serial_putchar(c); return 1; }
304+
size_t write(uint8_t c) override { serial_putchar(c); return 1; }
305305
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
306306
virtual size_t write(long n) { return write((uint8_t)n); }
307307
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
308308
virtual size_t write(int n) { return write((uint8_t)n); }
309-
virtual size_t write(const uint8_t *buffer, size_t size)
309+
size_t write(const uint8_t *buffer, size_t size) override
310310
{ serial_write(buffer, size); return size; }
311311
virtual size_t write(const char *str) { size_t len = strlen(str);
312312
serial_write((const uint8_t *)str, len);
@@ -346,21 +346,21 @@ class HardwareSerial2 : public HardwareSerial
346346
virtual void setTX(uint8_t pin, bool opendrain=false) { serial2_set_tx(pin, opendrain); }
347347
virtual bool attachRts(uint8_t pin) { return serial2_set_rts(pin); }
348348
virtual bool attachCts(uint8_t pin) { return serial2_set_cts(pin); }
349-
virtual int available(void) { return serial2_available(); }
350-
virtual int peek(void) { return serial2_peek(); }
351-
virtual int read(void) { return serial2_getchar(); }
352-
virtual void flush(void) { serial2_flush(); }
349+
int available(void) override { return serial2_available(); }
350+
int peek(void) override { return serial2_peek(); }
351+
int read(void) override { return serial2_getchar(); }
352+
void flush(void) override { serial2_flush(); }
353353
virtual void clear(void) { serial2_clear(); }
354-
virtual int availableForWrite(void) { return serial2_write_buffer_free(); }
354+
int availableForWrite(void) override { return serial2_write_buffer_free(); }
355355
virtual void addMemoryForRead(void *buffer, size_t length) {serial2_add_memory_for_read(buffer, length);}
356356
virtual void addMemoryForWrite(void *buffer, size_t length){serial2_add_memory_for_write(buffer, length);}
357357
using Print::write;
358-
virtual size_t write(uint8_t c) { serial2_putchar(c); return 1; }
358+
size_t write(uint8_t c) override { serial2_putchar(c); return 1; }
359359
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
360360
virtual size_t write(long n) { return write((uint8_t)n); }
361361
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
362362
virtual size_t write(int n) { return write((uint8_t)n); }
363-
virtual size_t write(const uint8_t *buffer, size_t size)
363+
size_t write(const uint8_t *buffer, size_t size) override
364364
{ serial2_write(buffer, size); return size; }
365365
virtual size_t write(const char *str) { size_t len = strlen(str);
366366
serial2_write((const uint8_t *)str, len);
@@ -385,21 +385,21 @@ class HardwareSerial3 : public HardwareSerial
385385
virtual void setTX(uint8_t pin, bool opendrain=false) { serial3_set_tx(pin, opendrain); }
386386
virtual bool attachRts(uint8_t pin) { return serial3_set_rts(pin); }
387387
virtual bool attachCts(uint8_t pin) { return serial3_set_cts(pin); }
388-
virtual int available(void) { return serial3_available(); }
389-
virtual int peek(void) { return serial3_peek(); }
390-
virtual int read(void) { return serial3_getchar(); }
391-
virtual void flush(void) { serial3_flush(); }
388+
int available(void) override { return serial3_available(); }
389+
int peek(void) override { return serial3_peek(); }
390+
int read(void) override { return serial3_getchar(); }
391+
void flush(void) override { serial3_flush(); }
392392
virtual void clear(void) { serial3_clear(); }
393-
virtual int availableForWrite(void) { return serial3_write_buffer_free(); }
393+
int availableForWrite(void) override { return serial3_write_buffer_free(); }
394394
virtual void addMemoryForRead(void *buffer, size_t length) {serial3_add_memory_for_read(buffer, length);}
395395
virtual void addMemoryForWrite(void *buffer, size_t length){serial3_add_memory_for_write(buffer, length);}
396396
using Print::write;
397-
virtual size_t write(uint8_t c) { serial3_putchar(c); return 1; }
397+
size_t write(uint8_t c) override { serial3_putchar(c); return 1; }
398398
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
399399
virtual size_t write(long n) { return write((uint8_t)n); }
400400
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
401401
virtual size_t write(int n) { return write((uint8_t)n); }
402-
virtual size_t write(const uint8_t *buffer, size_t size)
402+
size_t write(const uint8_t *buffer, size_t size) override
403403
{ serial3_write(buffer, size); return size; }
404404
virtual size_t write(const char *str) { size_t len = strlen(str);
405405
serial3_write((const uint8_t *)str, len);
@@ -424,21 +424,21 @@ class HardwareSerial4 : public HardwareSerial
424424
virtual void setTX(uint8_t pin, bool opendrain=false) { serial4_set_tx(pin, opendrain); }
425425
virtual bool attachRts(uint8_t pin) { return serial4_set_rts(pin); }
426426
virtual bool attachCts(uint8_t pin) { return serial4_set_cts(pin); }
427-
virtual int available(void) { return serial4_available(); }
428-
virtual int peek(void) { return serial4_peek(); }
429-
virtual int read(void) { return serial4_getchar(); }
430-
virtual void flush(void) { serial4_flush(); }
427+
int available(void) override { return serial4_available(); }
428+
int peek(void) override { return serial4_peek(); }
429+
int read(void) override { return serial4_getchar(); }
430+
void flush(void) override { serial4_flush(); }
431431
virtual void clear(void) { serial4_clear(); }
432-
virtual int availableForWrite(void) { return serial4_write_buffer_free(); }
432+
int availableForWrite(void) override { return serial4_write_buffer_free(); }
433433
virtual void addMemoryForRead(void *buffer, size_t length) {serial4_add_memory_for_read(buffer, length);}
434434
virtual void addMemoryForWrite(void *buffer, size_t length){serial4_add_memory_for_write(buffer, length);}
435435
using Print::write;
436-
virtual size_t write(uint8_t c) { serial4_putchar(c); return 1; }
436+
size_t write(uint8_t c) override { serial4_putchar(c); return 1; }
437437
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
438438
virtual size_t write(long n) { return write((uint8_t)n); }
439439
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
440440
virtual size_t write(int n) { return write((uint8_t)n); }
441-
virtual size_t write(const uint8_t *buffer, size_t size)
441+
size_t write(const uint8_t *buffer, size_t size) override
442442
{ serial4_write(buffer, size); return size; }
443443
virtual size_t write(const char *str) { size_t len = strlen(str);
444444
serial4_write((const uint8_t *)str, len);
@@ -463,21 +463,21 @@ class HardwareSerial5 : public HardwareSerial
463463
virtual void setTX(uint8_t pin, bool opendrain=false) { serial5_set_tx(pin, opendrain); }
464464
virtual bool attachRts(uint8_t pin) { return serial5_set_rts(pin); }
465465
virtual bool attachCts(uint8_t pin) { return serial5_set_cts(pin); }
466-
virtual int available(void) { return serial5_available(); }
467-
virtual int peek(void) { return serial5_peek(); }
468-
virtual int read(void) { return serial5_getchar(); }
469-
virtual void flush(void) { serial5_flush(); }
466+
int available(void) override { return serial5_available(); }
467+
int peek(void) override { return serial5_peek(); }
468+
int read(void) override { return serial5_getchar(); }
469+
void flush(void) override { serial5_flush(); }
470470
virtual void clear(void) { serial5_clear(); }
471-
virtual int availableForWrite(void) { return serial5_write_buffer_free(); }
471+
int availableForWrite(void) override { return serial5_write_buffer_free(); }
472472
virtual void addMemoryForRead(void *buffer, size_t length) {serial5_add_memory_for_read(buffer, length);}
473473
virtual void addMemoryForWrite(void *buffer, size_t length){serial5_add_memory_for_write(buffer, length);}
474474
using Print::write;
475-
virtual size_t write(uint8_t c) { serial5_putchar(c); return 1; }
475+
size_t write(uint8_t c) override { serial5_putchar(c); return 1; }
476476
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
477477
virtual size_t write(long n) { return write((uint8_t)n); }
478478
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
479479
virtual size_t write(int n) { return write((uint8_t)n); }
480-
virtual size_t write(const uint8_t *buffer, size_t size)
480+
size_t write(const uint8_t *buffer, size_t size) override
481481
{ serial5_write(buffer, size); return size; }
482482
virtual size_t write(const char *str) { size_t len = strlen(str);
483483
serial5_write((const uint8_t *)str, len);
@@ -509,21 +509,21 @@ class HardwareSerial6 : public HardwareSerial
509509
virtual void setTX(uint8_t pin, bool opendrain=false) { serial6_set_tx(pin, opendrain); }
510510
virtual bool attachRts(uint8_t pin) { return serial6_set_rts(pin); }
511511
virtual bool attachCts(uint8_t pin) { return serial6_set_cts(pin); }
512-
virtual int available(void) { return serial6_available(); }
513-
virtual int peek(void) { return serial6_peek(); }
514-
virtual int read(void) { return serial6_getchar(); }
515-
virtual void flush(void) { serial6_flush(); }
512+
int available(void) override { return serial6_available(); }
513+
int peek(void) override { return serial6_peek(); }
514+
int read(void) override { return serial6_getchar(); }
515+
void flush(void) override { serial6_flush(); }
516516
virtual void clear(void) { serial6_clear(); }
517-
virtual int availableForWrite(void) { return serial6_write_buffer_free(); }
517+
int availableForWrite(void) override { return serial6_write_buffer_free(); }
518518
virtual void addMemoryForRead(void *buffer, size_t length) {serial6_add_memory_for_read(buffer, length);}
519519
virtual void addMemoryForWrite(void *buffer, size_t length){serial6_add_memory_for_write(buffer, length);}
520520
using Print::write;
521-
virtual size_t write(uint8_t c) { serial6_putchar(c); return 1; }
521+
size_t write(uint8_t c) override { serial6_putchar(c); return 1; }
522522
virtual size_t write(unsigned long n) { return write((uint8_t)n); }
523523
virtual size_t write(long n) { return write((uint8_t)n); }
524524
virtual size_t write(unsigned int n) { return write((uint8_t)n); }
525525
virtual size_t write(int n) { return write((uint8_t)n); }
526-
virtual size_t write(const uint8_t *buffer, size_t size)
526+
size_t write(const uint8_t *buffer, size_t size) override
527527
{ serial6_write(buffer, size); return size; }
528528
virtual size_t write(const char *str) { size_t len = strlen(str);
529529
serial6_write((const uint8_t *)str, len);

teensy3/IPAddress.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class IPAddress : public Printable {
115115
return *this;
116116
}
117117

118-
virtual size_t printTo(Print& p) const;
118+
size_t printTo(Print& p) const override;
119119

120120
friend class EthernetClass;
121121
friend class UDP;

teensy3/usb_keyboard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class usb_keyboard_class : public Print
7373
public:
7474
void begin(void) { }
7575
void end(void) { }
76-
virtual size_t write(uint8_t c) { usb_keyboard_write(c); return 1; }
76+
size_t write(uint8_t c) override { usb_keyboard_write(c); return 1; }
7777
size_t write(unsigned long n) { return write((uint8_t)n); }
7878
size_t write(long n) { return write((uint8_t)n); }
7979
size_t write(unsigned int n) { return write((uint8_t)n); }

teensy3/usb_seremu.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,17 +82,17 @@ class usb_seremu_class : public Stream
8282
}
8383
}
8484
void end() { /* TODO: flush output and shut down USB port */ };
85-
virtual int available() { return usb_seremu_available(); }
86-
virtual int read() { return usb_seremu_getchar(); }
87-
virtual int peek() { return usb_seremu_peekchar(); }
88-
virtual void flush() { usb_seremu_flush_output(); }
89-
virtual size_t write(uint8_t c) { return usb_seremu_putchar(c); }
90-
virtual size_t write(const uint8_t *buffer, size_t size) { return usb_seremu_write(buffer, size); }
85+
int available() override { return usb_seremu_available(); }
86+
int read() override { return usb_seremu_getchar(); }
87+
int peek() override { return usb_seremu_peekchar(); }
88+
void flush() override { usb_seremu_flush_output(); }
89+
size_t write(uint8_t c) override { return usb_seremu_putchar(c); }
90+
size_t write(const uint8_t *buffer, size_t size) override { return usb_seremu_write(buffer, size); }
9191
size_t write(unsigned long n) { return write((uint8_t)n); }
9292
size_t write(long n) { return write((uint8_t)n); }
9393
size_t write(unsigned int n) { return write((uint8_t)n); }
9494
size_t write(int n) { return write((uint8_t)n); }
95-
virtual int availableForWrite() { return usb_seremu_write_buffer_free(); }
95+
int availableForWrite() override { return usb_seremu_write_buffer_free(); }
9696
using Print::write;
9797
void send_now(void) { usb_seremu_flush_output(); };
9898
uint32_t baud(void) { return 9600; }
@@ -120,17 +120,17 @@ class usb_seremu_class : public Stream
120120
constexpr usb_seremu_class() {}
121121
void begin(long) { };
122122
void end() { };
123-
virtual int available() { return 0; }
124-
virtual int read() { return -1; }
125-
virtual int peek() { return -1; }
126-
virtual void flush() { }
127-
virtual size_t write(uint8_t c) { return 1; }
128-
virtual size_t write(const uint8_t *buffer, size_t size) { return size; }
123+
int available() override { return 0; }
124+
int read() override { return -1; }
125+
int peek() override { return -1; }
126+
void flush() override { }
127+
size_t write(uint8_t c) override { return 1; }
128+
size_t write(const uint8_t *buffer, size_t size) override { return size; }
129129
size_t write(unsigned long n) { return 1; }
130130
size_t write(long n) { return 1; }
131131
size_t write(unsigned int n) { return 1; }
132132
size_t write(int n) { return 1; }
133-
virtual int availableForWrite() { return 0; }
133+
int availableForWrite() override { return 0; }
134134
using Print::write;
135135
void send_now(void) { }
136136
uint32_t baud(void) { return 0; }

teensy3/usb_serial.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -91,18 +91,18 @@ class usb_serial_class : public Stream
9191
}
9292
}
9393
void end() { /* TODO: flush output and shut down USB port */ };
94-
virtual int available() { return usb_serial_available(); }
95-
virtual int read() { return usb_serial_getchar(); }
96-
virtual int peek() { return usb_serial_peekchar(); }
97-
virtual void flush() { usb_serial_flush_output(); } // TODO: actually wait for data to leave USB...
94+
int available() override { return usb_serial_available(); }
95+
int read() override { return usb_serial_getchar(); }
96+
int peek() override { return usb_serial_peekchar(); }
97+
void flush() override { usb_serial_flush_output(); } // TODO: actually wait for data to leave USB...
9898
virtual void clear(void) { usb_serial_flush_input(); }
99-
virtual size_t write(uint8_t c) { return usb_serial_putchar(c); }
100-
virtual size_t write(const uint8_t *buffer, size_t size) { return usb_serial_write(buffer, size); }
99+
size_t write(uint8_t c) override { return usb_serial_putchar(c); }
100+
size_t write(const uint8_t *buffer, size_t size) override { return usb_serial_write(buffer, size); }
101101
size_t write(unsigned long n) { return write((uint8_t)n); }
102102
size_t write(long n) { return write((uint8_t)n); }
103103
size_t write(unsigned int n) { return write((uint8_t)n); }
104104
size_t write(int n) { return write((uint8_t)n); }
105-
virtual int availableForWrite() { return usb_serial_write_buffer_free(); }
105+
int availableForWrite() override { return usb_serial_write_buffer_free(); }
106106
using Print::write;
107107
void send_now(void) { usb_serial_flush_output(); }
108108
uint32_t baud(void) { return usb_cdc_line_coding[0]; }
@@ -144,18 +144,18 @@ class usb_serial_class : public Stream
144144
constexpr usb_serial_class() {}
145145
void begin(long) { };
146146
void end() { };
147-
virtual int available() { return 0; }
148-
virtual int read() { return -1; }
149-
virtual int peek() { return -1; }
150-
virtual void flush() { }
147+
int available() override { return 0; }
148+
int read() override { return -1; }
149+
int peek() override { return -1; }
150+
void flush() override { }
151151
virtual void clear() { }
152-
virtual size_t write(uint8_t c) { return 1; }
153-
virtual size_t write(const uint8_t *buffer, size_t size) { return size; }
152+
size_t write(uint8_t c) override { return 1; }
153+
size_t write(const uint8_t *buffer, size_t size) override { return size; }
154154
size_t write(unsigned long n) { return 1; }
155155
size_t write(long n) { return 1; }
156156
size_t write(unsigned int n) { return 1; }
157157
size_t write(int n) { return 1; }
158-
virtual int availableForWrite() { return 0; }
158+
int availableForWrite() override { return 0; }
159159
using Print::write;
160160
void send_now(void) { }
161161
uint32_t baud(void) { return 0; }

0 commit comments

Comments
 (0)