Enable the new return-value-checker=full (#3271)

Author: PaulWoitaschek

core/data/api/src/main/kotlin/voice/core/data/repo/BookmarkRepo.kt

@@ -9,6 +9,7 @@ public interface BookmarkRepo {
 
   public suspend fun addBookmark(bookmark: Bookmark)
 
+  @IgnorableReturnValue
   public suspend fun addBookmarkAtBookPosition(
     book: Book,
     title: String?,

core/data/impl/src/main/kotlin/voice/core/data/repo/BookContentRepoImpl.kt

@@ -66,7 +66,7 @@ public class BookContentRepoImpl(private val dao: BookContentDao) : BookContentR
           content.copy(isActive = content.id in ids)
         }
       }!!
-      .onEach { dao.insert(it) }
+      .forEach { dao.insert(it) }
   }
 
   override suspend fun put(content: BookContent) {

core/data/impl/src/main/kotlin/voice/core/data/repo/internals/migrations/Migration24to25.kt

@@ -79,7 +79,6 @@ public class Migration24to25 : IncrementalMigration(24) {
       var playingInformation: JSONObject? = null
       try {
         if (configFileValid) {
-          configFile.readText(Charsets.UTF_8)
           val retString = configFile.readText(Charsets.UTF_8)
           if (retString.isNotEmpty()) {
             playingInformation = JSONObject(retString)
@@ -179,7 +178,7 @@ public class Migration24to25 : IncrementalMigration(24) {
       if (name.isEmpty()) {
         name = if (chapterPaths.size == 1) {
           val chapterPath = chapterPaths.first()
-          chapterPath.substring(0, chapterPath.lastIndexOf("."))
+          chapterPath.take(chapterPath.lastIndexOf("."))
         } else {
           File(root).name
         }

core/data/impl/src/main/kotlin/voice/core/data/repo/internals/transaction.kt

@@ -2,6 +2,7 @@ package voice.core.data.repo.internals
 
 import androidx.sqlite.db.SupportSQLiteDatabase
 
+@IgnorableReturnValue
 internal inline fun <T> SupportSQLiteDatabase.transaction(
   exclusive: Boolean = true,
   body: SupportSQLiteDatabase.() -> T,

core/playback/src/main/kotlin/voice/core/playback/PlayerController.kt

@@ -164,6 +164,7 @@ class PlayerController(
     }
   }
 
+  @IgnorableReturnValue
   suspend fun awaitConnect(): MediaController? {
     return try {
       controller.await()

core/playback/src/main/kotlin/voice/core/playback/player/VoicePlayer.kt

@@ -345,15 +345,12 @@ class VoicePlayer(
     }
   }
 
-  fun setSkipSilenceEnabled(enabled: Boolean): Boolean {
+  fun setSkipSilenceEnabled(enabled: Boolean) {
     scope.launch {
       updateBook { it.copy(skipSilence = enabled) }
     }
-    return if (player is ExoPlayer) {
+    if (player is ExoPlayer) {
       player.skipSilenceEnabled = enabled
-      true
-    } else {
-      false
     }
   }
 

core/playback/src/test/kotlin/voice/core/playback/player/VoicePlayerTest.kt

@@ -69,7 +69,6 @@ class VoicePlayerTest {
           val chapter = currentBook.chapters.single {
             it.id == (mediaId.toMediaIdOrNull()!! as MediaId.Chapter).chapterId
           }
-          chapter.duration
           FakeMediaSource(
             FakeTimeline(
               FakeTimeline.TimelineWindowDefinition.Builder()
@@ -334,6 +333,7 @@ class VoicePlayerTest {
     TestPlayerRunHelper.runUntilPlaybackState(internalPlayer, Player.STATE_READY)
   }
 
+  @IgnorableReturnValue
   private fun Player.shouldHavePosition(
     currentMediaItemIndex: Int,
     currentPosition: Long,

core/scanner/src/main/kotlin/voice/core/scanner/BookParser.kt

@@ -80,6 +80,7 @@ internal fun validateIntegrity(
   chapters: List<Chapter>,
 ) {
   // the init block performs integrity validation
+  @Suppress("RETURN_VALUE_NOT_USED")
   Book(content, chapters)
 }
 

core/scanner/src/test/kotlin/voice/core/scanner/MediaScannerTest.kt

@@ -221,6 +221,7 @@ class MediaScannerTest {
       scanner.scan(mapOf(type to roots.map(::FileBasedDocumentFile)))
     }
 
+    @IgnorableReturnValue
     fun audioFile(
       parent: File,
       name: String,

core/search/src/test/kotlin/voice/core/search/BookSearchTest.kt

@@ -190,6 +190,7 @@ private class TestBase(private val search: BookSearch) {
   }
 
   suspend fun search(query: String) {
+    @Suppress("RETURN_VALUE_NOT_USED")
     search.search(query)
   }
 }