Skip to content

Commit affad0a

Browse files
committed
Added configuration for decimal to prevent EF warnings
1 parent 7a5b1a6 commit affad0a

File tree

5 files changed

+33
-4
lines changed

5 files changed

+33
-4
lines changed

samples/Thinktecture.EntityFrameworkCore.Benchmarks/Database/SqlServerBenchmarkDbContext.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,19 @@ public SqlServerBenchmarkDbContext(DbContextOptions<SqlServerBenchmarkDbContext>
77
{
88
}
99

10+
/// <inheritdoc />
11+
protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
12+
{
13+
configurationBuilder.Properties<decimal>(builder => builder
14+
.HavePrecision(18, 5)
15+
.HaveColumnType("decimal(18, 5)"));
16+
}
17+
1018
/// <inheritdoc />
1119
protected override void OnModelCreating(ModelBuilder modelBuilder)
1220
{
1321
base.OnModelCreating(modelBuilder);
1422

15-
modelBuilder.ConfigureScalarCollectionParameter<decimal>(builder => builder.Property(e => e.Value).HasPrecision(10, 4));
16-
1723
modelBuilder.ConfigureComplexCollectionParameter<MyParameter>();
1824

1925
modelBuilder.ConfigureTempTableEntity<MyParameter>();

samples/Thinktecture.EntityFrameworkCore.SqlServer.Samples/Database/DemoDbContext.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@ public DemoDbContext(DbContextOptions<DemoDbContext> options, IDbDefaultSchema?
2121
Schema = schema?.Schema;
2222
}
2323

24+
/// <inheritdoc />
25+
protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
26+
{
27+
configurationBuilder.Properties<decimal>(builder => builder
28+
.HavePrecision(18, 5)
29+
.HaveColumnType("decimal(18, 5)"));
30+
}
31+
2432
/// <inheritdoc />
2533
protected override void OnModelCreating(ModelBuilder modelBuilder)
2634
{

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/EntityFrameworkCore/TempTables/SqlServerTempTableCreatorTests/CreateTempTableAsync.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ public async Task Should_create_temp_table_with_decimal()
530530
[Fact]
531531
public async Task Should_create_temp_table_with_decimal_with_explicit_precision()
532532
{
533-
ConfigureModel = builder => builder.ConfigureTempTable<decimal>(typeBuilder => typeBuilder.Property(t => t.Column1).HasColumnType("decimal(20,5)"));
533+
ConfigureModel = builder => builder.ConfigureTempTable<decimal>(typeBuilder => typeBuilder.Property(t => t.Column1).HasPrecision(20,5));
534534

535535
await using var tempTable = await SUT.CreateTempTableAsync(ActDbContext.GetTempTableEntityType<TempTable<decimal>>(), _optionsWithNonUniqueName);
536536

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/Extensions/SqlServerOperationBuilderExtensionsTests/MigrationExtensionsTestDbContext.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ public MigrationExtensionsTestDbContext(DbContextOptions<MigrationExtensionsTest
99
{
1010
}
1111

12+
/// <inheritdoc />
13+
protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
14+
{
15+
configurationBuilder.Properties<decimal>(builder => builder
16+
.HavePrecision(18, 5)
17+
.HaveColumnType("decimal(18, 5)"));
18+
}
19+
1220
protected override void OnModelCreating(ModelBuilder modelBuilder)
1321
{
1422
base.OnModelCreating(modelBuilder);
@@ -63,7 +71,6 @@ INNER JOIN SYS.INDEX_COLUMNS AS c
6371
AND i.index_id = {indexId};");
6472
}
6573

66-
6774
public IQueryable<UniqueConstraint> GetUniqueConstraints(string constraintName)
6875
{
6976
ArgumentNullException.ThrowIfNull(constraintName);

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/TestDatabaseContext/TestDbContext.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,14 @@ public TestDbContext(DbContextOptions<TestDbContext> options, IDbDefaultSchema?
4545
Schema = schema?.Schema;
4646
}
4747

48+
/// <inheritdoc />
49+
protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
50+
{
51+
configurationBuilder.Properties<decimal>(builder => builder
52+
.HavePrecision(18, 5)
53+
.HaveColumnType("decimal(18, 5)"));
54+
}
55+
4856
protected override void OnModelCreating(ModelBuilder modelBuilder)
4957
{
5058
base.OnModelCreating(modelBuilder);

0 commit comments

Comments
 (0)