Added configuration for decimal to prevent EF warnings

Author: PawelGerr

samples/Thinktecture.EntityFrameworkCore.Benchmarks/Database/SqlServerBenchmarkDbContext.cs

@@ -7,13 +7,19 @@ public SqlServerBenchmarkDbContext(DbContextOptions<SqlServerBenchmarkDbContext>
    {
    }
 
+   /// <inheritdoc />
+   protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
+   {
+      configurationBuilder.Properties<decimal>(builder => builder
+                                                          .HavePrecision(18, 5)
+                                                          .HaveColumnType("decimal(18, 5)"));
+   }
+
    /// <inheritdoc />
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
       base.OnModelCreating(modelBuilder);
 
-      modelBuilder.ConfigureScalarCollectionParameter<decimal>(builder => builder.Property(e => e.Value).HasPrecision(10, 4));
-
       modelBuilder.ConfigureComplexCollectionParameter<MyParameter>();
 
       modelBuilder.ConfigureTempTableEntity<MyParameter>();

samples/Thinktecture.EntityFrameworkCore.SqlServer.Samples/Database/DemoDbContext.cs

@@ -21,6 +21,14 @@ public DemoDbContext(DbContextOptions<DemoDbContext> options, IDbDefaultSchema?
       Schema = schema?.Schema;
    }
 
+   /// <inheritdoc />
+   protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
+   {
+      configurationBuilder.Properties<decimal>(builder => builder
+                                                          .HavePrecision(18, 5)
+                                                          .HaveColumnType("decimal(18, 5)"));
+   }
+
    /// <inheritdoc />
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/EntityFrameworkCore/TempTables/SqlServerTempTableCreatorTests/CreateTempTableAsync.cs

@@ -530,7 +530,7 @@ public async Task Should_create_temp_table_with_decimal()
    [Fact]
    public async Task Should_create_temp_table_with_decimal_with_explicit_precision()
    {
-      ConfigureModel = builder => builder.ConfigureTempTable<decimal>(typeBuilder => typeBuilder.Property(t => t.Column1).HasColumnType("decimal(20,5)"));
+      ConfigureModel = builder => builder.ConfigureTempTable<decimal>(typeBuilder => typeBuilder.Property(t => t.Column1).HasPrecision(20,5));
 
       await using var tempTable = await SUT.CreateTempTableAsync(ActDbContext.GetTempTableEntityType<TempTable<decimal>>(), _optionsWithNonUniqueName);
 

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/Extensions/SqlServerOperationBuilderExtensionsTests/MigrationExtensionsTestDbContext.cs

@@ -9,6 +9,14 @@ public MigrationExtensionsTestDbContext(DbContextOptions<MigrationExtensionsTest
    {
    }
 
+   /// <inheritdoc />
+   protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
+   {
+      configurationBuilder.Properties<decimal>(builder => builder
+                                                          .HavePrecision(18, 5)
+                                                          .HaveColumnType("decimal(18, 5)"));
+   }
+
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
       base.OnModelCreating(modelBuilder);
@@ -63,7 +71,6 @@ INNER JOIN SYS.INDEX_COLUMNS AS c
    AND i.index_id = {indexId};");
    }
 
-
    public IQueryable<UniqueConstraint> GetUniqueConstraints(string constraintName)
    {
       ArgumentNullException.ThrowIfNull(constraintName);

tests/Thinktecture.EntityFrameworkCore.SqlServer.Tests/TestDatabaseContext/TestDbContext.cs

@@ -45,6 +45,14 @@ public TestDbContext(DbContextOptions<TestDbContext> options, IDbDefaultSchema?
       Schema = schema?.Schema;
    }
 
+   /// <inheritdoc />
+   protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
+   {
+      configurationBuilder.Properties<decimal>(builder => builder
+                                                          .HavePrecision(18, 5)
+                                                          .HaveColumnType("decimal(18, 5)"));
+   }
+
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
       base.OnModelCreating(modelBuilder);