Migration-tx must be disposed

Author: PawelGerr

Directory.Build.props

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <Copyright>(c) $([System.DateTime]::Now.Year), Pawel Gerr. All rights reserved.</Copyright>
-    <VersionPrefix>4.4.0</VersionPrefix>
+    <VersionPrefix>4.4.1</VersionPrefix>
     <Authors>Pawel Gerr</Authors>    
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageProjectUrl>https://dev.azure.com/pawelgerr/Thinktecture.EntityFrameworkCore</PackageProjectUrl>

src/Thinktecture.EntityFrameworkCore.SqlServer.Testing/EntityFrameworkCore/Testing/SqlServerTestDbContextProvider.cs

@@ -203,6 +203,18 @@ protected virtual IDbContextTransaction BeginTransaction(T ctx)
       return ctx.Database.BeginTransaction(_sharedTablesIsolationLevel);
    }
 
+   /// <summary>
+   /// Starts a new transaction for migration and cleanup.
+   /// </summary>
+   /// <param name="ctx">Database context.</param>
+   /// <returns>An instance of <see cref="IDbContextTransaction"/>.</returns>
+   protected virtual IDbContextTransaction? BeginMigrationAndCleanupTransaction(T ctx)
+   {
+      ArgumentNullException.ThrowIfNull(ctx);
+
+      return ctx.Database.BeginTransaction(_migrationAndCleanupIsolationLevel);
+   }
+
    /// <summary>
    /// Runs migrations for provided <paramref name="ctx" />.
    /// </summary>
@@ -224,15 +236,16 @@ protected virtual void RunMigrations(T ctx)
             IDbContextTransaction? migrationTx = null;
 
             if (ctx.Database.CurrentTransaction is null)
-               migrationTx = ctx.Database.BeginTransaction(_migrationAndCleanupIsolationLevel);
+               migrationTx = BeginMigrationAndCleanupTransaction(ctx);
 
             try
             {
                _migrationExecutionStrategy.Migrate(ctx);
+               migrationTx?.Commit();
             }
             finally
             {
-               migrationTx?.Commit();
+               migrationTx?.Dispose();
             }
          }
          finally
@@ -294,15 +307,16 @@ private void DisposeContextsAndRollbackMigrations()
             IDbContextTransaction? migrationTx = null;
 
             if (ctx.Database.CurrentTransaction is null)
-               migrationTx = ctx.Database.BeginTransaction(_migrationAndCleanupIsolationLevel);
+               migrationTx = BeginMigrationAndCleanupTransaction(ctx);
 
             try
             {
                _isolationOptions.Cleanup(ctx, Schema);
+               migrationTx?.Commit();
             }
             finally
             {
-               migrationTx?.Commit();
+               migrationTx?.Dispose();
             }
          }
       }