eslint-config-mocha (#622)

Use the latest version of eslint-config-base, and take a dependency on eslint-config-mocha now that test linting has been moved to a standalone library.

eslint-config-base previously assumed that you would always use Mocha, but some of our projects actually use Jest (which is better than Mocha). It's a bit messy to require devDependencies related to Mocha if you actually use Jest, so I split out the test linting config into a standalone library.

Now we need to take a dependency on that library so our tests still get linted 😄 .

Author: 0xCLARITY

.eslintrc.js

@@ -22,7 +22,7 @@ module.exports = {
 
   plugins: ['import', 'node'],
 
-  extends: ['@xpring-eng/eslint-config-base/loose'],
+  extends: ['@xpring-eng/eslint-config-mocha', '@xpring-eng/eslint-config-base/loose'],
 
   rules: {
     // We explicitly use `process.exit()` because all other errors should really be handled.

package-lock.json

@@ -59,7 +59,8 @@
     "@types/supertest": "^2.0.10",
     "@typescript-eslint/eslint-plugin": "^3.7.0",
     "@typescript-eslint/parser": "^3.7.0",
-    "@xpring-eng/eslint-config-base": "^0.10.0",
+    "@xpring-eng/eslint-config-base": "^0.11.0",
+    "@xpring-eng/eslint-config-mocha": "^1.0.0",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "chokidar": "^3.4.0",