Skip to content

Commit 9999ae0

Browse files
Merge pull request #118 from blundell/androidx_update
Update to AndroidX from support lib
2 parents e31e000 + 2e16446 commit 9999ae0

File tree

10 files changed

+19
-14
lines changed

10 files changed

+19
-14
lines changed

build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,5 @@ ext {
3232
versionCode = 18
3333

3434
buildToolsVersion = "29.0.2"
35-
supportLibraryVersion = "28.0.0"
3635
versionName = "3.1.2"
3736
}

example/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ android {
2525
}
2626

2727
dependencies {
28-
implementation "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"
28+
implementation 'androidx.appcompat:appcompat:1.2.0'
2929
implementation fileTree(include: ['*.jar'], dir: 'libs')
3030
testImplementation 'junit:junit:4.13-beta-2'
3131
testImplementation 'org.assertj:assertj-core:3.12.2'

example/src/main/java/co/paystack/example/MainActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
import android.app.ProgressDialog;
44
import android.os.AsyncTask;
55
import android.os.Bundle;
6-
import android.support.v7.app.AppCompatActivity;
76
import android.view.Menu;
87
import android.view.View;
98
import android.widget.Button;
109
import android.widget.EditText;
1110
import android.widget.TextView;
1211
import android.widget.Toast;
1312

13+
import androidx.appcompat.app.AppCompatActivity;
14+
1415
import org.json.JSONException;
1516

1617
import java.io.BufferedReader;

example/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<resources>
22

33
<!-- Base application theme. -->
4-
<style name="AppTheme" parent="Theme.AppCompat.Light">
4+
<style name="AppTheme" parent="@style/Theme.AppCompat.Light">
55
<!-- Customize your theme here. -->
66
</style>
77

gradle.properties

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,10 @@
1616
# This option should only be used with decoupled projects. More details, visit
1717
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
1818
# org.gradle.parallel=true
19-
android.useAndroidX=true
19+
20+
# This is neccessary because we use 'co.paystack.android.design.widget:pinpad:1.0.4'
21+
# Once pinpad has been updated (https://github.com/PaystackHQ/library-android-pinpad/pull/6)
22+
# Then android.enableJetifier=true can be deleted and full AndroidX migration is complete
23+
android.enableJetifier=true
24+
25+
android.useAndroidX=true

paystack/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ dependencies {
2929
implementation 'com.squareup.retrofit2:retrofit:2.9.0'
3030
implementation 'com.squareup.retrofit2:converter-gson:2.5.0'
3131
implementation 'com.squareup.okhttp3:okhttp:3.14.9'
32-
implementation "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"
32+
implementation 'androidx.appcompat:appcompat:1.2.0'
3333
implementation 'co.paystack.android.design.widget:pinpad:1.0.4'
3434
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
3535
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.7"

paystack/src/main/java/co/paystack/android/ui/AddressVerificationActivity.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
package co.paystack.android.ui
22

33
import android.os.Bundle
4-
import android.support.v7.app.AppCompatActivity
5-
import android.support.v7.widget.ListPopupWindow
64
import android.text.Editable
75
import android.text.TextWatcher
86
import android.util.Log
97
import android.view.View
108
import android.view.WindowManager
119
import android.widget.*
10+
import androidx.appcompat.app.AppCompatActivity
1211
import co.paystack.android.R
1312
import co.paystack.android.mobilemoney.data.api.PaystackApiFactory
1413
import co.paystack.android.model.AvsState
@@ -99,7 +98,7 @@ class AddressVerificationActivity : AppCompatActivity(), CoroutineScope {
9998

10099
private fun validateForm() {
101100
val isValid = etStreet.text.isNotBlank() && etCity.text.toString().isNotBlank() &&
102-
etZipCode.text.toString().isNotBlank() && selectedState != null
101+
etZipCode.text.toString().isNotBlank() && selectedState != null
103102

104103
btnConfirm.isEnabled = isValid
105104
}

paystack/src/main/java/co/paystack/android/ui/CardActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
package co.paystack.android.ui;
22

33
import android.os.Bundle;
4-
import android.support.v7.app.AppCompatActivity;
54
import android.view.KeyEvent;
65
import android.view.View;
76
import android.view.WindowManager;
87
import android.widget.Button;
98
import android.widget.EditText;
109
import android.widget.TextView;
1110

11+
import androidx.appcompat.app.AppCompatActivity;
12+
1213
import co.paystack.android.R;
1314
import co.paystack.android.model.Card;
1415

paystack/src/main/java/co/paystack/android/ui/PinActivity.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package co.paystack.android.ui;
22

33
import android.os.Bundle;
4-
import android.support.v7.app.AppCompatActivity;
54
import android.view.WindowManager;
65

6+
import androidx.appcompat.app.AppCompatActivity;
7+
78
import co.paystack.android.R;
89
import co.paystack.android.design.widget.PinPadView;
910

@@ -53,6 +54,4 @@ public void onDestroy() {
5354
}
5455

5556

56-
57-
5857
}

paystack/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
33

4-
<style name="Paystack.Dialog" parent="Theme.AppCompat">
4+
<style name="Paystack.Dialog" parent="@style/Theme.AppCompat">
55
<item name="android:windowNoTitle">true</item>
66
<item name="android:windowBackground">@android:color/transparent</item>
77
<item name="android:colorBackgroundCacheHint">@null</item>

0 commit comments

Comments
 (0)