Fix switch fallthrough warning in generator.hpp

claude · claude · commit ba21005ad900 · 2025-12-21T22:18:28.000Z
Add [[fallthrough]] attribute after std::rethrow_exception to silence
compiler warning about missing return/break.
diff --git a/cpp/include/mh/coroutine/generator.hpp b/cpp/include/mh/coroutine/generator.hpp
@@ -53,7 +53,7 @@ namespace mh
 				// Nothing to do
 			}
 
-			const_reference& value() const
+			[[nodiscard]] const_reference& value() const
 			{
 				switch (m_State.index())
 				{
@@ -63,6 +63,7 @@ namespace mh
 					return *std::get<1>(m_State);
 				case 2:
 					std::rethrow_exception(std::get<2>(m_State));
+					[[fallthrough]];
 				default:
 					throw std::logic_error("invalid promise state");
 				}

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ namespace mh`
`53`	`53`	`// Nothing to do`
`54`	`54`	`}`
`55`	`55`
`56`		`- const_reference& value() const`
	`56`	`+ [[nodiscard]] const_reference& value() const`
`57`	`57`	`{`
`58`	`58`	`switch (m_State.index())`
`59`	`59`	`{`
`@@ -63,6 +63,7 @@ namespace mh`
`63`	`63`	`return *std::get<1>(m_State);`
`64`	`64`	`case 2:`
`65`	`65`	`std::rethrow_exception(std::get<2>(m_State));`
	`66`	`+ [[fallthrough]];`
`66`	`67`	`default:`
`67`	`68`	`throw std::logic_error("invalid promise state");`
`68`	`69`	`}`