Merge pull request #99 from Mansi-dass/Mansi-dass-GitHubAction

Another trial for linter Issue

Author: dlebauer

.github/workflows/interface_test.yml

@@ -7,30 +7,28 @@ on:
 
 jobs:
   interface_test:
-
     runs-on: ubuntu-latest
     defaults:
-        run:
-          working-directory: interface
-
+      run:
+        working-directory: interface
     strategy:
       matrix:
-        node-version: [12.x, 14.x]
+        node-version: [16, 18]
 
     steps:
-    - name: Checkout repository
-      uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v3.5.1
 
-    - name: Set up Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
+      - name: Set up Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3.6.0
+        with:
+          node-version: ${{ matrix.node-version }}
 
-    - name: Install dependencies
-      run: npm install
+      - name: Install dependencies
+        run: npm install
 
-    - name: Run the tests and generate coverage report
-      run: npm test -- --coverage
+      - name: Run the tests and generate coverage report
+        run: npm test -- --coverage
 
-    - name: Upload coverage to Codecov
-      uses: codecov/codecov-action@v1
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3.1.2

.github/workflows/linter.yml

@@ -7,19 +7,19 @@ on:
 
 jobs:
   lint:
-    
     runs-on: ubuntu-latest
-
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v2
-        
+      - name: Checkout code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+          ref: ${{ github.head_ref }}
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+
       - name: Lint Code Base
-        uses: docker://github/super-linter:v3
+        uses: github/super-linter@v4
         env:
-          PYTHON_PYLINT_CONFIG_FILE: .pylintrc
           VALIDATE_ALL_CODEBASE: false
-          VALIDATE_PYTHON_PYLINT: true
-          VALIDATE_JAVASCRIPT_ES: true
-          DEFAULT_BRANCH: master
+          DEFAULT_BRANCH: "master"
+          PYTHON_PYLINT_CONFIG_FILE: .pylintrc
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/py_tests.yml

@@ -10,45 +10,42 @@ on:
 
 jobs:
   py_test:
-
     runs-on: ubuntu-latest
     strategy:
       matrix:
+        ports: ["9000:5432", "8000:8000", "5001:5000", "6001:6000", "8008:8075", "3001:3000"]
         code: [ app, client]
         include:
-         - code: app
-           path: ./yaba_test/test_yaba.py
-         - code: client
-           path: ./yaba_client_test/test_yaba_client.py
+          - code: app
+            path: ./yaba_test/test_yaba.py
+          - code: client
+            path: ./yaba_client_test/test_yaba_client.py
 
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
-      - name: Set up Python 3.7
-        uses: actions/setup-python@v2
+      - name: Set up Python 3.10
+        uses: actions/setup-python@v3
         with:
-          python-version: 3.7
+          python-version: '3.10'
+          cache: 'pip'
 
       - name: Install dependencies
         run: |
               pip install --upgrade pip
-              pip install pytest
-              pip install pytest-cov
+              pip install pytest pytest-cov
               pip install docker-compose
-              
+
       - name: Set-up the project
         run: |
-              docker-compose up -d postgres
-              docker-compose run --rm bety initialize
-              docker-compose up -d
-              docker ps -a
-              docker logs betydb-yaba_yaba_api_1
+              docker-compose -p bety up -d postgres
+              docker run --rm --network bety_bety pecan/db
 
       - name: Test with pytest and generate coverage report
         run: |
-              sleep 20
-              pytest --cov= ${{ matrix.path }} --cov-report=xml
-
+              chmod +x wait-for-server.sh
+              bash ./wait-for-server.sh ${{ matrix.ports }} pytest --cov= ${{ matrix.path }} --cov-report=xml
+      
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3

wait-for-server.sh

@@ -0,0 +1,14 @@
+#!/bin/bash
+
+set -e
+
+host="$1"
+shift
+cmd="$*"
+
+until curl --silent --output /dev/null --fail "http://$host"; do
+  echo "Waiting for server..."
+  sleep 5
+done
+
+exec $cmd