updated test

Author: blesson-07

modules/uncertainty/tests/testthat/test_ensemble.R

@@ -16,7 +16,7 @@ make_input_sets <- function(paths) {
 
 # Helper: make ensemble.samples with the correct structure
 make_samples <- function(samples) {
-  list(input = data.frame(samples = samples, stringsAsFactors = FALSE))
+  lapply(paths, function(p) list(path = p))
 }
 
 # 1. One input, no samples → should pass
@@ -53,19 +53,86 @@ test_that("no input error", {
 
 
 
-test_that("multiple inputs, valid matching samples ", {
-  settings <- list(run = list(inputs = list(input = NULL)))  # or missing/empty paths
-  ensemble.samples <- make_samples(c("IC1", "IC2", "IC3", "IC2"))
-  defaults <- list()
+
 
-  # Capture logger message, but don't stop execution
-  expect_silent(write.ensemble.configs(
-    defaults = defaults,
-    ensemble.samples = ensemble.samples,
-    settings = settings,
-    model = "SIPNET",
-    write.to.db = FALSE
-  ))
+
+
+
+test_that("multiple inputs and multiple samples", {
+  # Mock the SIPNET config writer
+  mockery::stub(write.ensemble.configs, "write.config.SIPNET", function(...) TRUE)
+  
+  # Create temp directories
+  temp_rundir <- tempfile()
+  temp_modeloutdir <- tempfile()
+  dir.create(temp_rundir)
+  dir.create(temp_modeloutdir)
+  on.exit({
+    unlink(temp_rundir, recursive = TRUE)
+    unlink(temp_modeloutdir, recursive = TRUE)
+  }, add = TRUE)
+  
+  # Complete settings
+  settings <- list(
+    run = list(
+      inputs = list(input = list(path = "IC1")),
+      site = list(id = 1, name = "Test Site"),
+      start.date = "2000-01-01",
+      end.date = "2000-12-31",
+      outdir = temp_modeloutdir
+    ),
+    ensemble = list(size = 5),
+    database = NULL,
+    rundir = temp_rundir,
+    modeloutdir = temp_modeloutdir,
+    host = list(
+      rundir = temp_rundir,
+      outdir = temp_modeloutdir
+    ),
+    model = list(id = "SIPNET", type = "SIPNET"),
+    pfts = list(
+      list(name = "temperate", 
+           constants = list(1),
+           posteriorid = 1)
+    )
+  )
+  
+  # Sample parameters
+  ensemble.samples <- list(
+    temperate = data.frame(
+      SLA = c(15.2, 16.8, 14.7, 18.1, 17.5),
+      Vm0 = c(45.0, 50.3, 47.8, 49.1, 51.0)
+    )
+  )
+  
+  # Default PFT settings
+  defaults <- list(
+    list(
+      name = "temperate",
+      constants = list(1),
+      posteriorid = 1
+    )
+  )
+  
+  # Run test - should create directories and configs
+  result <- expect_silent(
+    write.ensemble.configs(
+      defaults = defaults,
+      ensemble.samples = ensemble.samples,
+      settings = settings,
+      model = "SIPNET",
+      write.to.db = FALSE
+    )
+  )
+  
+  # Verify outputs
+  expect_type(result, "list")
+  expect_named(result, c("runs", "ensemble.id", "samples"))
+  expect_equal(nrow(result$runs), settings$ensemble$size)
 })
 
 
+
+  
+
+