Skip to content

Commit 43cee7c

Browse files
authored
scheduled tasks: restart activity while ctx.Err() == nil (#3381)
Scheduler workflow was seen to be completed in Temporal in certain scenarios. This PR aims to prevent that
1 parent 20675c8 commit 43cee7c

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

flow/workflows/scheduled_flows.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,13 @@ func ScheduledTasksWorkflow(ctx workflow.Context) error {
7272
MaximumInterval: 1 * time.Minute,
7373
},
7474
})
75-
scheduledTasksFuture := workflow.ExecuteActivity(ctx, flowable.ScheduledTasks)
76-
if err := scheduledTasksFuture.Get(ctx, nil); err != nil {
77-
return err
75+
for {
76+
scheduledTasksFuture := workflow.ExecuteActivity(ctx, flowable.ScheduledTasks)
77+
if err := scheduledTasksFuture.Get(ctx, nil); err != nil {
78+
return err
79+
}
80+
if err := ctx.Err(); err != nil {
81+
return err
82+
}
7883
}
79-
return ctx.Err()
8084
}

0 commit comments

Comments
 (0)