better error handling for getPartitions (#3742)

jgao54 · web-flow · commit 7916790a3bd3 · 2025-11-26T16:06:27.000-10:00
make sure `getPartitions` error gets surfaced right away to make log
less confusing.
diff --git a/flow/connectors/postgres/qrep.go b/flow/connectors/postgres/qrep.go
@@ -73,13 +73,16 @@ func (c *PostgresConnector) GetQRepPartitions(
 	}
 
 	partitions, err := c.getPartitions(ctx, getPartitionsTx, config, last)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get partitions: %w", err)
+	}
 
 	// commit transaction
 	if err := getPartitionsTx.Commit(ctx); err != nil {
 		return nil, fmt.Errorf("failed to commit transaction: %w", err)
 	}
 
-	return partitions, err
+	return partitions, nil
 }
 
 func (c *PostgresConnector) GetDefaultPartitionKeyForTables(

Original file line number	Diff line number	Diff line change
`@@ -73,13 +73,16 @@ func (c *PostgresConnector) GetQRepPartitions(`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`partitions, err := c.getPartitions(ctx, getPartitionsTx, config, last)`
	`76`	`+ if err != nil {`
	`77`	`+ return nil, fmt.Errorf("failed to get partitions: %w", err)`
	`78`	`+ }`
`76`	`79`
`77`	`80`	`// commit transaction`
`78`	`81`	`if err := getPartitionsTx.Commit(ctx); err != nil {`
`79`	`82`	`return nil, fmt.Errorf("failed to commit transaction: %w", err)`
`80`	`83`	`}`
`81`	`84`
`82`		`- return partitions, err`
	`85`	`+ return partitions, nil`
`83`	`86`	`}`
`84`	`87`
`85`	`88`	`func (c *PostgresConnector) GetDefaultPartitionKeyForTables(`