Skip to content

Commit aa53a69

Browse files
authored
classify: still use isClickHouseMvError with QRepSyncError (#3344)
got MV error in qrep without FROM
1 parent 3fdb93d commit aa53a69

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

flow/alerting/classifier.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,9 @@ func GetErrorClass(ctx context.Context, err error) (ErrorClass, ErrorInfo) {
467467
691, // UNKNOWN_ELEMENT_OF_ENUM
468468
chproto.ErrNoCommonType,
469469
chproto.ErrIllegalTypeOfArgument:
470+
if isClickHouseMvError(chException) {
471+
return ErrorNotifyMVOrView, chErrorInfo
472+
}
470473
var qrepSyncError *exceptions.QRepSyncError
471474
if errors.As(err, &qrepSyncError) {
472475
unexpectedSelectRe, reErr := regexp.Compile(
@@ -480,8 +483,6 @@ func GetErrorClass(ctx context.Context, err error) (ErrorClass, ErrorInfo) {
480483
if unexpectedSelectRe.MatchString(chException.Message) {
481484
return ErrorNotifyMVOrView, chErrorInfo
482485
}
483-
} else if isClickHouseMvError(chException) {
484-
return ErrorNotifyMVOrView, chErrorInfo
485486
}
486487
case chproto.ErrQueryWasCancelled, chproto.ErrPocoException, chproto.ErrCannotReadFromSocket:
487488
return ErrorRetryRecoverable, chErrorInfo

0 commit comments

Comments
 (0)