Skip to content

Commit ef7a921

Browse files
fix(postgres): remove retrying on checking connection active (#3535)
Co-authored-by: Copilot <[email protected]>
1 parent aa7a4ee commit ef7a921

File tree

1 file changed

+3
-31
lines changed

1 file changed

+3
-31
lines changed

flow/connectors/postgres/ssh_wrapped_conn.go

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@ package connpostgres
22

33
import (
44
"context"
5-
"fmt"
65
"log/slog"
76
"net"
8-
"time"
97

108
"github.com/jackc/pgx/v5"
11-
"go.temporal.io/sdk/log"
129

1310
"github.com/PeerDB-io/peerdb/flow/connectors/utils"
1411
"github.com/PeerDB-io/peerdb/flow/internal"
@@ -55,40 +52,15 @@ func NewPostgresConnFromConfig(
5552
}
5653
conn, err := pgx.ConnectConfig(ctx, connConfig)
5754
if err != nil {
58-
logger.Error("Failed to create pool", slog.Any("error", err))
55+
logger.Error("Failed to create connection", slog.Any("error", err))
5956
return nil, err
6057
}
6158

62-
if err := retryWithBackoff(logger, func() error {
63-
if _, err := conn.Exec(ctx, "SELECT 1"); err != nil {
64-
logger.Error("Failed to ping pool", slog.Any("error", err), slog.String("host", connConfig.Host))
65-
return err
66-
}
67-
return nil
68-
}, 5, 5*time.Second); err != nil {
69-
logger.Error("Failed to create pool", slog.Any("error", err), slog.String("host", connConfig.Host))
59+
if _, err := conn.Exec(ctx, "SELECT 1"); err != nil {
60+
logger.Error("Failed to ping connection", slog.Any("error", err), slog.String("host", connConfig.Host))
7061
conn.Close(ctx)
7162
return nil, err
7263
}
7364

7465
return conn, nil
7566
}
76-
77-
type retryFunc func() error
78-
79-
func retryWithBackoff(logger log.Logger, fn retryFunc, maxRetries int, backoff time.Duration) error {
80-
i := 0
81-
for {
82-
err := fn()
83-
if err == nil {
84-
return nil
85-
}
86-
i += 1
87-
if i < maxRetries {
88-
logger.Info(fmt.Sprintf("Attempt #%d failed, retrying in %s", i+1, backoff))
89-
time.Sleep(backoff)
90-
} else {
91-
return err
92-
}
93-
}
94-
}

0 commit comments

Comments
 (0)