Skip to content

Commit 1f19415

Browse files
committed
i finally understand the point of this prop
it should be set by targetId if its a block with a monitor that is sprite dependent
1 parent 76ca928 commit 1f19415

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/lib/make-toolbox-xml.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,8 @@ const looks = function (isInitialSetup, isStage, targetId, costumeName, backdrop
269269
</shadow>
270270
</value>
271271
</block>
272-
<block type="looks_sayWidth"></block>
273-
<block type="looks_sayHeight"></block>
272+
<block id="${targetId}_sayWidth" type="looks_sayWidth"></block>
273+
<block id="${targetId}_sayHeight" type="looks_sayHeight"></block>
274274
${blockSeparator}
275275
`}
276276
${isStage ? `
@@ -355,8 +355,8 @@ const looks = function (isInitialSetup, isStage, targetId, costumeName, backdrop
355355
</shadow>
356356
</value>
357357
</block>
358-
<block type="looks_stretchGetX"></block>
359-
<block type="looks_stretchGetY"></block>
358+
<block id="${targetId}_stretchGetX" type="looks_stretchGetX"></block>
359+
<block id="${targetId}_stretchGetY" type="looks_stretchGetY"></block>
360360
`}
361361
${blockSeparator}
362362
<block type="looks_changeeffectby">
@@ -379,13 +379,13 @@ const looks = function (isInitialSetup, isStage, targetId, costumeName, backdrop
379379
</value>
380380
</block>
381381
<block type="looks_cleargraphiceffects"/>
382-
<block type="looks_getEffectValue"/>
383-
<block type="looks_tintColor"/>
382+
<block id="${targetId}_getEffectValue" type="looks_getEffectValue"/>
383+
<block id="${targetId}_tintColor" type="looks_tintColor"/>
384384
${blockSeparator}
385385
${isStage ? '' : `
386386
<block type="looks_show"/>
387387
<block type="looks_hide"/>
388-
<block type="looks_getSpriteVisible"/>
388+
<block id="${targetId}_getSpriteVisible" type="looks_getSpriteVisible"/>
389389
${blockSeparator}
390390
<block type="looks_changeVisibilityOfSpriteShow">
391391
<value name="VISIBLE_OPTION">
@@ -423,7 +423,7 @@ const looks = function (isInitialSetup, isStage, targetId, costumeName, backdrop
423423
<shadow type="looks_getOtherSpriteVisible_menu"/>
424424
</value>
425425
</block>
426-
<block type="looks_layersGetLayer"></block>
426+
<block id="${targetId}_layersGetLayer" type="looks_layersGetLayer"></block>
427427
${blockSeparator}
428428
`}
429429
${isStage ? `
@@ -533,7 +533,7 @@ const sound = function (isInitialSetup, isStage, targetId, soundName) {
533533
</value>
534534
</block>
535535
<block type="sound_cleareffects"/>
536-
<block type="sound_getEffectValue"/>
536+
<block id="${targetId}_soundgetEffectValue" type="sound_getEffectValue"/>
537537
${blockSeparator}
538538
<block type="sound_changevolumeby">
539539
<value name="VOLUME">
@@ -732,7 +732,7 @@ const control = function (isInitialSetup, isStage) {
732732
`;
733733
};
734734

735-
const sensing = function (isInitialSetup, isStage) {
735+
const sensing = function (isInitialSetup, isStage, targetId) {
736736
const name = translate('SENSING_ASK_TEXT', 'What\'s your name?');
737737
// const openDocumentation = translate('OPEN_DOCUMENTATION', 'Open Documentation');
738738
const helpManual = translate('HELP_MANUAL', 'Help Manual');
@@ -879,7 +879,7 @@ const sensing = function (isInitialSetup, isStage) {
879879
${isStage ? '' : `
880880
${blockSeparator}
881881
<block type="sensing_setdragmode" id="sensing_setdragmode"></block>
882-
<block type="sensing_getdragmode" id="sensing_getdragmode"></block>
882+
<block id="${targetId}_getdragmode" type="sensing_getdragmode"></block>
883883
${blockSeparator}
884884
`}
885885
${blockSeparator}

0 commit comments

Comments
 (0)