Skip to content

Commit 2d37eff

Browse files
rauletorrescrauletorresc
authored
Rename properties of Python version info of Linux Arm64 workflow (#1018)
**Context:** Python version properties were named "official" and "subversion". For example, for "Python 3.9.19", "3.9" would be the "official" property and "19" would be "subversion" property. **Description of the Change:** "official" is now "major_minor", while "subversion" is now "patch". **Benefits:** It reflects better the naming convention for Python packages.
1 parent dcbc683 commit 2d37eff

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

‎.github/workflows/build-wheel-linux-arm64.yaml‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ jobs:
3737
strategy:
3838
fail-fast: false
3939
matrix:
40-
python_version: [{official: "3.9", subversion: "19", package: "python39"}]
40+
python_version: [{major_minor: "3.9", patch: "19", package: "python39"}]
4141
container_img: ["quay.io/pypa/manylinux_2_28_aarch64"]
4242
container_name: ["manylinux_2_28_aarch64"]
4343

44-
name: Build Dependencies (Python ${{ matrix.python_version.official }})
44+
name: Build Dependencies (Python ${{ matrix.python_version.major_minor }})
4545
runs-on:
4646
group: 'Office 24th floor M2 Mac'
4747

@@ -55,7 +55,7 @@ jobs:
5555
id: setup_env
5656
uses: ./.github/workflows/utils/setup_self_hosted_macos_env_linux_arm64
5757
with:
58-
python_version: ${{ matrix.python_version.official }}
58+
python_version: ${{ matrix.python_version.major_minor }}
5959

6060
# Cache external project sources
6161
- name: Cache LLVM Source
@@ -140,7 +140,7 @@ jobs:
140140
-v /var/run/docker.sock:/var/run/docker.sock \
141141
-v `pwd`:/catalyst \
142142
-i ${{ matrix.container_img }} \
143-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_lld.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }}
143+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_lld.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }}
144144
145145
- name: Build LLVM / MLIR
146146
if: steps.cache-llvm-build.outputs.cache-hit != 'true'
@@ -152,7 +152,7 @@ jobs:
152152
-v /var/run/docker.sock:/var/run/docker.sock \
153153
-v `pwd`:/catalyst \
154154
-i ${{ matrix.container_img }} \
155-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_llvm.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }}
155+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_llvm.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }}
156156
157157
- name: Save LLVM Build
158158
id: save-llvm-build
@@ -171,7 +171,7 @@ jobs:
171171
-v /var/run/docker.sock:/var/run/docker.sock \
172172
-v `pwd`:/catalyst \
173173
-i ${{ matrix.container_img }} \
174-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_mhlo.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }}
174+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_mhlo.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }}
175175
176176
- name: Save MHLO Build
177177
id: save-mhlo-build
@@ -190,7 +190,7 @@ jobs:
190190
-v /var/run/docker.sock:/var/run/docker.sock \
191191
-v `pwd`:/catalyst \
192192
-i ${{ matrix.container_img }} \
193-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_enzyme.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }}
193+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_enzyme.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }}
194194
195195
- name: Save Enzyme Build
196196
id: save-enzyme-build
@@ -206,14 +206,14 @@ jobs:
206206
fail-fast: false
207207
max-parallel: 2
208208
matrix:
209-
python_version: [{official: "3.9", subversion: "19", package: "python39", alternative: "39"},
210-
{official: "3.10", subversion: "14", package: "python3.10", alternative: "310"},
211-
{official: "3.11", subversion: "9", package: "python3.11", alternative: "311"},
212-
{official: "3.12", subversion: "3", package: "python3.12", alternative: "312"}]
209+
python_version: [{major_minor: "3.9", patch: "19", package: "python39", alternative: "39"},
210+
{major_minor: "3.10", patch: "14", package: "python3.10", alternative: "310"},
211+
{major_minor: "3.11", patch: "9", package: "python3.11", alternative: "311"},
212+
{major_minor: "3.12", patch: "3", package: "python3.12", alternative: "312"}]
213213
container_img: ["quay.io/pypa/manylinux_2_28_aarch64"]
214214
container_name: ["manylinux_2_28_aarch64"]
215215

216-
name: Build Wheels (Python ${{ matrix.python_version.official }})
216+
name: Build Wheels (Python ${{ matrix.python_version.major_minor }})
217217
runs-on:
218218
group: 'Office 24th floor M2 Mac'
219219

@@ -225,7 +225,7 @@ jobs:
225225
id: setup_env
226226
uses: ./.github/workflows/utils/setup_self_hosted_macos_env_linux_arm64
227227
with:
228-
python_version: ${{ matrix.python_version.official }}
228+
python_version: ${{ matrix.python_version.major_minor }}
229229

230230
- name: Get Cached LLVM Source
231231
id: cache-llvm-source
@@ -287,12 +287,12 @@ jobs:
287287
-v /var/run/docker.sock:/var/run/docker.sock \
288288
-v `pwd`:/catalyst \
289289
-i ${{ matrix.container_img }} \
290-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_catalyst.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }} ${{ matrix.python_version.alternative }}
290+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/build_catalyst.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }} ${{ matrix.python_version.alternative }}
291291
292292
- name: Upload Wheel Artifact
293293
uses: actions/upload-artifact@v4
294294
with:
295-
name: catalyst-linux_arm64-wheel-py-${{ matrix.python_version.official}}.zip
295+
name: catalyst-linux_arm64-wheel-py-${{ matrix.python_version.major_minor}}.zip
296296
path: wheel/
297297
retention-days: 14
298298

@@ -302,15 +302,15 @@ jobs:
302302
fail-fast: false
303303
max-parallel: 2
304304
matrix:
305-
python_version: [{official: "3.9", subversion: "19", package: "python39"},
306-
{official: "3.10", subversion: "14", package: "python3.10"},
307-
{official: "3.11", subversion: "9", package: "python3.11"},
308-
{official: "3.12", subversion: "3", package: "python3.12"}]
305+
python_version: [{major_minor: "3.9", patch: "19", package: "python39"},
306+
{major_minor: "3.10", patch: "14", package: "python3.10"},
307+
{major_minor: "3.11", patch: "9", package: "python3.11"},
308+
{major_minor: "3.12", patch: "3", package: "python3.12"}]
309309
container_img: ["quay.io/pypa/manylinux_2_28_aarch64"]
310310
container_name: ["manylinux_2_28_aarch64"]
311311

312312
# To check all wheels for supported python3 versions
313-
name: Test Wheels (Python ${{ matrix.python_version.official }})
313+
name: Test Wheels (Python ${{ matrix.python_version.major_minor }})
314314
runs-on:
315315
group: 'Office 24th floor M2 Mac'
316316

@@ -322,12 +322,12 @@ jobs:
322322
id: setup_env
323323
uses: ./.github/workflows/utils/setup_self_hosted_macos_env_linux_arm64
324324
with:
325-
python_version: ${{ matrix.python_version.official }}
325+
python_version: ${{ matrix.python_version.major_minor }}
326326

327327
- name: Download Wheel Artifact
328328
uses: actions/download-artifact@v4
329329
with:
330-
name: catalyst-linux_arm64-wheel-py-${{ matrix.python_version.official }}.zip
330+
name: catalyst-linux_arm64-wheel-py-${{ matrix.python_version.major_minor }}.zip
331331
path: dist
332332

333333
# Needed for accessing llvm-symbolizer
@@ -347,4 +347,4 @@ jobs:
347347
-v /var/run/docker.sock:/var/run/docker.sock \
348348
-v `pwd`:/catalyst \
349349
-i ${{ matrix.container_img }} \
350-
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/test_wheels.sh $GCC_VERSION ${{ matrix.python_version.official }} ${{ matrix.python_version.subversion }} ${{ matrix.python_version.package }}
350+
bash /catalyst/.github/workflows/scripts/linux_arm64/rh8/test_wheels.sh $GCC_VERSION ${{ matrix.python_version.major_minor }} ${{ matrix.python_version.patch }} ${{ matrix.python_version.package }}

0 commit comments

Comments
 (0)