#33 Adding a team member as not-admin not handled properly

Signed-off-by: Kai Wagner <[email protected]>

Author: ImTheKai

app/assets/stylesheets/components/settings.css

@@ -22,6 +22,22 @@
   color: var(--color-text-primary);
 }
 
+.settings-page .settings-hint {
+  margin-bottom: var(--spacing-4);
+  color: var(--color-text-secondary);
+  font-size: var(--font-size-sm);
+}
+
+.settings-page fieldset[disabled] {
+  opacity: 0.6;
+  cursor: not-allowed;
+}
+
+.settings-page fieldset[disabled] input,
+.settings-page fieldset[disabled] button {
+  cursor: not-allowed;
+}
+
 .settings-warning {
   margin-bottom: var(--spacing-4);
   color: var(--color-warning-text);

app/controllers/settings/teams_controller.rb

@@ -15,7 +15,8 @@ def index
     def show
       @team_members = @team.team_members.includes(:user)
       @can_manage = user_signed_in? && @team.admin?(current_user)
-      @can_invite = user_signed_in? && (@team.member?(current_user) || @team.admin?(current_user))
+      @can_invite = user_signed_in? && @team.admin?(current_user)
+      @can_view_invite = user_signed_in? && @team.member?(current_user)
     end
 
     def create

app/views/settings/teams/show.html.slim

@@ -21,11 +21,14 @@
     - else
       p No members yet.
 
-  - if @can_invite
+  - if @can_view_invite
     .invite-section
       h2 Add member
+      - unless @can_invite
+        p.settings-hint Only team admins can add members.
       = form_with url: settings_team_team_members_path(@team), method: :post, local: true do |f|
-        .form-group
-          = label_tag :username, "Username"
-          = text_field_tag :username, nil, required: true, placeholder: "existing_username"
-        = f.submit "Add", class: "button-primary"
+        fieldset disabled=(!@can_invite)
+          .form-group
+            = label_tag :username, "Username"
+            = text_field_tag :username, nil, required: true, placeholder: "existing_username"
+          = f.submit "Add", class: "button-primary"