Also generate migration errors in production

dutow · dutow · commit c8a733d65b64 · 2026-01-17T21:28:51.000+01:00
diff --git a/app/middleware/pending_migration_catcher.rb b/app/middleware/pending_migration_catcher.rb
@@ -7,13 +7,13 @@ def initialize(app)
 
   def call(env)
     @app.call(env)
-  rescue ActiveRecord::PendingMigrationError, ActiveRecord::NoDatabaseError => e
-    render_maintenance_page(e)
+  rescue ActiveRecord::PendingMigrationError, ActiveRecord::NoDatabaseError
+    render_maintenance_page
   end
 
   private
 
-  def render_maintenance_page(_error)
+  def render_maintenance_page
     html = <<~HTML
       <!DOCTYPE html>
       <html>
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -92,6 +92,9 @@
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
 
+  # Raise PendingMigrationError on page load when migrations are pending.
+  config.active_record.migration_error = :page_load
+
   # Only use :id for inspections in production.
   config.active_record.attributes_for_inspect = [ :id ]
 
diff --git a/config/routes.rb b/config/routes.rb
@@ -8,7 +8,7 @@
 
   if Rails.env.development?
     get "preview/maintenance" => ->(env) {
-      PendingMigrationCatcher.new(nil).send(:render_maintenance_page, nil)
+      PendingMigrationCatcher.new(nil).send(:render_maintenance_page)
     }
   end
   get "messages/by-id/*message_id", to: "messages#by_message_id", as: :message_by_id, format: false

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`if Rails.env.development?`
`10`	`10`	`get "preview/maintenance" => ->(env) {`
`11`		`- PendingMigrationCatcher.new(nil).send(:render_maintenance_page, nil)`
	`11`	`+ PendingMigrationCatcher.new(nil).send(:render_maintenance_page)`
`12`	`12`	`}`
`13`	`13`	`end`
`14`	`14`	`get "messages/by-id/*message_id", to: "messages#by_message_id", as: :message_by_id, format: false`