PS-10014 feature: Add Valgrind testing to the CI

https://perconadev.atlassian.net/browse/PS-10014

Added new step to GitHub Actions. We now run MTR under Valgrind for
"GCC 14 Debug" configuration.

Author: percona-ysorokin

.github/workflows/cmake.yml

@@ -67,6 +67,7 @@ jobs:
             name: "GCC 14 Debug",
             label: "debug_gcc14",
             run_mtr: true,
+            run_valgrind_mtr: true,
             run_ctest: true
           }
         - {
@@ -136,8 +137,13 @@ jobs:
       run: |
         sudo apt-get install g++-14
 
+    - name: Install Valgrind on ubuntu
+      if: matrix.config.run_valgrind_mtr
+      run: |
+        sudo apt-get install valgrind
+
     - name: Fixing libaio1 for MySQL Server tarball
-      if: matrix.config.run_mtr
+      if: matrix.config.run_mtr || matrix.config.run_valgrind_mtr
       run: |
         sudo apt-get install libaio-dev
         sudo ln -s libaio.so /lib/x86_64-linux-gnu/libaio.so.1
@@ -249,15 +255,16 @@ jobs:
       run: run-clang-tidy-20 -header-filter=.* -j=${{steps.cpu-cores.outputs.count}} -use-color -p=${{github.workspace}}/src-build-${{matrix.config.label}}
 
     - name: Application version
+      if: false
       working-directory: ${{github.workspace}}/src-build-${{matrix.config.label}}
       run: ./binlog_server version
 
     - name: Creating DIST directory for MySQL Server tarballs
-      if: matrix.config.run_mtr
+      if: matrix.config.run_mtr || matrix.config.run_valgrind_mtr
       run: mkdir -p ${{github.workspace}}/dist
 
     - name: Unpacking MySQL Server 8.0 tarballs
-      if: matrix.config.run_mtr
+      if: matrix.config.run_mtr || matrix.config.run_valgrind_mtr
       working-directory: ${{github.workspace}}/dist
       run: |
         # https://dev.mysql.com/get/Downloads/MySQL-8.0/mysql-8.0.45-linux-glibc2.28-x86_64.tar.xz
@@ -276,7 +283,7 @@ jobs:
         ./${DIST_BASE_NAME}/bin/mysqld --version
 
     - name: Unpacking MySQL Server 8.4 tarballs
-      if: matrix.config.run_mtr
+      if: matrix.config.run_mtr || matrix.config.run_valgrind_mtr
       working-directory: ${{github.workspace}}/dist
       run: |
         # https://dev.mysql.com/get/Downloads/MySQL-8.4/mysql-8.4.8-linux-glibc2.28-x86_64-minimal.tar.xz
@@ -303,6 +310,15 @@ jobs:
           --force --max-test-fail=0 --retry=0 --nounit-tests --big-test --repeat=2 --parallel=${{steps.cpu-cores.outputs.count}} \
           --suite=binlog_streaming ${{matrix.config.mtr_options}}
 
+    - name: MTR 8.0 tests (Valgrind)
+      if: matrix.config.run_valgrind_mtr
+      working-directory: ${{github.workspace}}/dist/${{format('mysql-{0}-{1}', env.MYSQL_80_VERSION, env.MYSQL_GLIBC_SUFFIX)}}/mysql-test
+      run: |
+        BINSRV=${{github.workspace}}/src-build-${{matrix.config.label}}/binlog_server ./mtr \
+          --vardir=${{runner.temp}}/mtrvardir80 \
+          --force --max-test-fail=0 --retry=0 --nounit-tests --big-test --parallel=${{steps.cpu-cores.outputs.count}} \
+          --suite=binlog_streaming --valgrind
+
     - name: MTR 8.4 tests
       if: matrix.config.run_mtr
       working-directory: ${{github.workspace}}/dist/${{format('mysql-{0}-{1}-minimal', env.MYSQL_84_VERSION, env.MYSQL_GLIBC_SUFFIX)}}/mysql-test
@@ -312,6 +328,15 @@ jobs:
           --force --max-test-fail=0 --retry=0 --nounit-tests --big-test --repeat=2 --parallel=${{steps.cpu-cores.outputs.count}} \
           --suite=binlog_streaming ${{matrix.config.mtr_options}}
 
+    - name: MTR 8.4 tests (Valgrind)
+      if: matrix.config.run_valgrind_mtr
+      working-directory: ${{github.workspace}}/dist/${{format('mysql-{0}-{1}-minimal', env.MYSQL_84_VERSION, env.MYSQL_GLIBC_SUFFIX)}}/mysql-test
+      run: |
+        BINSRV=${{github.workspace}}/src-build-${{matrix.config.label}}/binlog_server ./mtr \
+          --vardir=${{runner.temp}}/mtrvardir84 \
+          --force --max-test-fail=0 --retry=0 --nounit-tests --big-test --parallel=${{steps.cpu-cores.outputs.count}} \
+          --suite=binlog_streaming --valgrind
+
     - name: CTest
       if: matrix.config.run_ctest
       working-directory: ${{github.workspace}}/src-build-${{matrix.config.label}}

src/app.cpp

@@ -1060,6 +1060,13 @@ extern "C" void custom_signal_handler(int /*signo*/) {
 int main(int argc, char *argv[]) {
   using namespace std::string_literals;
 
+  [[maybe_unused]] auto *ptr{new std::byte[1024]};
+  ptr[512] = static_cast<std::byte>(42U);
+  std::function<void(std::byte *)> deleter{
+      [](auto *pointer) { delete[] pointer; }};
+  deleter(ptr);
+  deleter(ptr);
+
   const auto cmd_args = util::to_command_line_agg_view(argc, argv);
   const auto executable_name = util::extract_executable_name(cmd_args);