Updated clang toolset to version 18 (WIP)

percona-ysorokin · percona-ysorokin · commit dc7ed6e63da2 · 2025-05-17T01:35:39.000+02:00
GitHub Actions workets now use 'ubuntu-24.04' image that have more recent
toolsets as a part of standard distribution.
'apt.llvm.org' package repository is no longer used for 'clang'.
'ppa:ubuntu-toolchain-r/test' repository is no longer used for 'gcc'.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -16,7 +16,7 @@ env:
 
 jobs:
   formatting-check:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     name: Formatting checks
     steps:
       - name: Cheking out source tree
@@ -37,24 +37,22 @@ jobs:
 
       - name: Install dependencies on ubuntu
         run: |
-          wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
-          echo deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main | sudo tee /etc/apt/sources.list.d/llvm.list
           sudo apt-get update
-          sudo apt-get install clang-format-17
+          sudo apt-get install clang-format-18
 
       - name: Info Clang Format
-        run: clang-format-17 --version
+        run: clang-format-18 --version
 
-      - name: Check formatting with git clang-format-17
+      - name: Check formatting with git clang-format-18
         working-directory: ${{github.workspace}}/src
-        run: git clang-format-17 --diff --binary=clang-format-17 HEAD~
+        run: git clang-format-18 --diff --binary=clang-format-18 HEAD~
 
   build:
     # The CMake configure and build commands are platform agnostic and should work equally well on Windows or Mac.
     # You can convert this to a matrix build if you need cross-platform coverage.
     # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
     name: ${{ matrix.config.name }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:
@@ -76,24 +74,20 @@ jobs:
             mtr_options: "--sanitize"
           }
         - {
-            name: "Clang 17 Debug",
-            label: "debug_clang17",
+            name: "Clang 18 Debug",
+            label: "debug_clang18",
             run_clang_tidy: true
           }
         - {
-            name: "Clang 17 RelWithDebInfo",
-            label: "release_clang17",
+            name: "Clang 18 RelWithDebInfo",
+            label: "release_clang18",
             run_clang_tidy: true
           }
         - {
-            name: "Clang 17 ASan",
-            label: "asan_clang17"
-            # TODO: re-enable running MTR under "Clang 17 ASan"
-            #   run_mtr: true,
-            #   mtr_options: "--sanitize"
-            # when "-stdlib=libc++ -fsanitize=address" alloc-dealloc-mismatch issue is fixed
-            # (https://github.com/llvm/llvm-project/issues/59432)
-            # or CI is upgraded to Clang 18
+            name: "Clang 18 ASan",
+            label: "asan_clang18",
+            run_mtr: true,
+            mtr_options: "--sanitize"
           }
 
     steps:
@@ -128,15 +122,12 @@ jobs:
     - name: Install Clang dependencies on ubuntu
       if: startsWith(matrix.config.name, 'Clang')
       run: |
-        wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
-        echo deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main | sudo tee /etc/apt/sources.list.d/llvm.list
         sudo apt-get update
-        sudo apt-get install clang-17 lld-17 clang-tidy-17 libc++-17-dev libc++1-17 libc++abi-17-dev libc++abi1-17
+        sudo apt-get install clang-18 lld-18 clang-tidy-18 libc++-18-dev libc++1-18 libc++abi-18-dev libc++abi1-18
 
     - name: Install GCC dependencies on ubuntu
       if: startsWith(matrix.config.name, 'GCC')
       run: |
-        sudo add-apt-repository ppa:ubuntu-toolchain-r/test
         sudo apt-get update
         sudo apt-get install g++-13
 
@@ -157,7 +148,7 @@ jobs:
       id: cache-boost-static-libraries
       uses: actions/cache@v4
       with:
-        path: ${{github.workspace}}/boost-install-${{matrix.config.label}}
+        path ${{github.workspace}}/boost-install-${{matrix.config.label}}
         key: ${{format('boost-static-libraries-{0}-{1}-{2}-{3}', env.BOOST_MAJOR, env.BOOST_MINOR, env.BOOST_PATCH, matrix.config.label)}}
 
     - name: Checking out Boost source tree
@@ -239,12 +230,12 @@ jobs:
 
     - name: Info Clang Tidy
       if: matrix.config.run_clang_tidy
-      run: clang-tidy-17 --version
+      run: clang-tidy-18 --version
 
     - name: Clang Tidy
       if: matrix.config.run_clang_tidy
       # Run Clang Tidy
-      run: run-clang-tidy-17 -header-filter=.* -j=${{steps.cpu-cores.outputs.count}} -use-color -p=${{github.workspace}}/src-build-${{matrix.config.label}}
+      run: run-clang-tidy-18 -header-filter=.* -j=${{steps.cpu-cores.outputs.count}} -use-color -p=${{github.workspace}}/src-build-${{matrix.config.label}}
 
     - name: MTR tests
       if: matrix.config.run_mtr
diff --git a/CMakePresets.json b/CMakePresets.json
@@ -51,11 +51,11 @@
       }
     },
     {
-      "name": "clang17_hidden",
+      "name": "clang18_hidden",
       "hidden": true,
       "cacheVariables": {
-        "CMAKE_C_COMPILER": "clang-17",
-        "CMAKE_CXX_COMPILER": "clang++-17",
+        "CMAKE_C_COMPILER": "clang-18",
+        "CMAKE_CXX_COMPILER": "clang++-18",
         "WITH_STDLIB_LIBCXX": "ON"
       }
     },
@@ -89,31 +89,31 @@
     },
 
     {
-      "name": "debug_clang17",
+      "name": "debug_clang18",
       "inherits": [
         "common_hidden",
         "debug_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 Debug"
+      "displayName": "Clang 18 Debug"
     },
     {
-      "name": "release_clang17",
+      "name": "release_clang18",
       "inherits": [
         "common_hidden",
         "release_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 RelWithDebInfo"
+      "displayName": "Clang 18 RelWithDebInfo"
     },
     {
-      "name": "asan_clang17",
+      "name": "asan_clang18",
       "inherits": [
         "common_hidden",
         "asan_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 ASan"
+      "displayName": "Clang 18 ASan"
     }
   ]
 }
diff --git a/README.md b/README.md
@@ -15,7 +15,7 @@ Currently prebuilt binaries are not available.
 #### Dependencies
 
 - [CMake](https://cmake.org/) 3.20.0+
-- [Clang](https://clang.llvm.org/) (`clang-15` / `clang-16` / `clang-17`) or [GCC](https://gcc.gnu.org/) (`gcc-12` / `gcc-13` / `gcc-14`)
+- [Clang](https://clang.llvm.org/) (`clang-15` .. `clang-18`) or [GCC](https://gcc.gnu.org/) (`gcc-12` .. `gcc-14`)
 - [Boost libraries](https://www.boost.org/) 1.88.0 (git version, not the source tarball)
 - [MySQL client library](https://dev.mysql.com/doc/c-api/8.0/en/) 8.0.x (`libmysqlclient`)
 - [CURL library](https://curl.se/libcurl/) (`libcurl`) 8.6.0+
@@ -44,7 +44,7 @@ Define `BUILD_PRESET` depending on whether you want to build in `Debug`, `Releas
 export BUILD_PRESET=<configuration>_<toolset>
 ```
 The supported values for `<configuration>` are `debug`, `release`, and `asan`.
-The supported values for `<toolset>` are `gcc13` and  `clang17`.
+The supported values for `<toolset>` are `gcc13` and  `clang18`.
 
 For instance, if you want to build in `RelWithDebInfo` configuration using `GCC 13`, please specify
 ```bash
diff --git a/extra/cmake_presets/aws-sdk-cpp/CMakePresets.json b/extra/cmake_presets/aws-sdk-cpp/CMakePresets.json
@@ -55,11 +55,11 @@
       }
     },
     {
-      "name": "clang17_hidden",
+      "name": "clang18_hidden",
       "hidden": true,
       "cacheVariables": {
-        "CMAKE_C_COMPILER": "clang-17",
-        "CMAKE_CXX_COMPILER": "clang++-17",
+        "CMAKE_C_COMPILER": "clang-18",
+        "CMAKE_CXX_COMPILER": "clang++-18",
         "CMAKE_CXX_FLAGS_INIT": "-stdlib=libc++"
       }
     },
@@ -93,31 +93,31 @@
     },
 
     {
-      "name": "debug_clang17",
+      "name": "debug_clang18",
       "inherits": [
         "common_hidden",
         "debug_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 Debug"
+      "displayName": "Clang 18 Debug"
     },
     {
-      "name": "release_clang17",
+      "name": "release_clang18",
       "inherits": [
         "common_hidden",
         "release_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 RelWithDebInfo"
+      "displayName": "Clang 18 RelWithDebInfo"
     },
     {
-      "name": "asan_clang17",
+      "name": "asan_clang18",
       "inherits": [
         "common_hidden",
         "asan_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 ASan"
+      "displayName": "Clang 18 ASan"
     }
   ]
 }
diff --git a/extra/cmake_presets/boost/CMakePresets.json b/extra/cmake_presets/boost/CMakePresets.json
@@ -53,11 +53,11 @@
       }
     },
     {
-      "name": "clang17_hidden",
+      "name": "clang18_hidden",
       "hidden": true,
       "cacheVariables": {
-        "CMAKE_C_COMPILER": "clang-17",
-        "CMAKE_CXX_COMPILER": "clang++-17"
+        "CMAKE_C_COMPILER": "clang-18",
+        "CMAKE_CXX_COMPILER": "clang++-18"
       },
       "environment": {
         "STDLIB_FLAGS": "-stdlib=libc++"
@@ -93,31 +93,31 @@
     },
 
     {
-      "name": "debug_clang17",
+      "name": "debug_clang18",
       "inherits": [
         "common_hidden",
         "debug_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 Debug"
+      "displayName": "Clang 18 Debug"
     },
     {
-      "name": "release_clang17",
+      "name": "release_clang18",
       "inherits": [
         "common_hidden",
         "release_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 RelWithDebInfo"
+      "displayName": "Clang 18 RelWithDebInfo"
     },
     {
-      "name": "asan_clang17",
+      "name": "asan_clang18",
       "inherits": [
         "common_hidden",
         "asan_hidden",
-        "clang17_hidden"
+        "clang18_hidden"
       ],
-      "displayName": "Clang 17 ASan"
+      "displayName": "Clang 18 ASan"
     }
   ]
 }
