Skip to content

Commit 32631d5

Browse files
committed
Update devtools to latest
Hash: 6865bf119d83444dbbc2a6a426612e20ea1e5ec6
1 parent 42ee4e1 commit 32631d5

File tree

2,346 files changed

+199538
-100044
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,346 files changed

+199538
-100044
lines changed

AUTHORS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ Jacky Hu <[email protected]>
4444
Jake Mulhern <[email protected]>
4545
Jan Keitel <[email protected]>
4646
Jeffrey Chen <[email protected]>
47-
Jesper van den Ende <[email protected]>
4847
Jerome Vouillon <[email protected]>
48+
Jesper van den Ende <[email protected]>
4949
Jithil p Ponnan <[email protected]>
5050
Juba Borgohain <[email protected]>
5151
Julian Geppert <[email protected]>
@@ -72,8 +72,10 @@ Rajasekar Murugan <[email protected]>
7272
Ross Wollman <[email protected]>
7373
Royi Hagigi <[email protected]>
7474
Ryan Puhalovich <[email protected]>
75+
Satvic Dhawan <[email protected]>
7576
Sebastian Markbåge <[email protected]>
7677
Serg Kryvonos <[email protected]>
78+
Sergio Avalos <[email protected]>
7779
Simon Siefke <[email protected]>
7880
Stephen Tsoi-A-Sue <[email protected]>
7981
Sunnylost <[email protected]>

DEPS

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,27 @@ vars = {
1212
'build_with_chromium': False,
1313

1414
'build_url': 'https://chromium.googlesource.com/chromium/src/build.git',
15-
'build_revision': '93926da1cd27aa9e3c7fe3650d9c0a2ca2373c30',
15+
'build_revision': '44bcc9d7b830ddf5d56e96bf8bc7fea9023bad6f',
1616

1717
'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
18-
'buildtools_revision': 'd1850bb09e7916134a5364ede6025a62c34ad113',
18+
'buildtools_revision': '2823e220cbd03e103d40b388974758ce46614ae2',
1919

2020
'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
21-
'depot_tools_revision': 'c4d75a151973a872ec74e33afb90acde64c48644',
21+
'depot_tools_revision': '58625e82c685426d441be5b422c9ad88e4867d20',
2222

2323
'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
24-
'inspector_protocol_revision': 'ccf6613682a24413db28656da6f9c52948331bad',
24+
'inspector_protocol_revision': '69d69ddf3aa698b171886551a4a672c5af1ad902',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '4c89c62053c88d1891413698f6f48fd1ae321c81',
27+
'chromium_browser_protocol_revision' : 'b53d566f0eff2aa1de7f7c33e3aa2deaa7774c37',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
30-
'clang_format_revision': '3c0acd2d4e73dd911309d9e970ba09d58bf23a62',
30+
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
3131

3232
'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
3333

3434
# GN CIPD package version.
35-
'gn_version': 'git_revision:feafd1012a32c05ec6095f69ddc3850afb621f3a',
35+
'gn_version': 'git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd',
3636

3737
'cmake_version': 'version:[email protected]',
3838

@@ -49,7 +49,7 @@ vars = {
4949
# Chrome version used for tests. It should be regularly updated to
5050
# match the Canary version listed here:
5151
# https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
52-
'chrome': '132.0.6779.0',
52+
'chrome': '133.0.6928.0',
5353

5454
# 'magic' text to tell depot_tools that git submodules should be accepted but
5555
# but parity with DEPS file is expected.
@@ -131,7 +131,7 @@ deps = {
131131
'packages': [
132132
{
133133
'package': 'infra/3pp/tools/esbuild/${{platform}}',
134-
'version': 'version:2@0.14.13.chromium.2',
134+
'version': 'version:3@0.24.0.chromium.2',
135135
}
136136
],
137137
'dep_type': 'cipd',
@@ -167,10 +167,10 @@ deps = {
167167
'bucket': 'chromium-nodejs',
168168
'objects': [
169169
{
170-
'object_name': '20.11.0/f9a337cfa0e2b92d3e5c671c26b454bd8e99769e',
171-
'sha256sum': '0ba9cc91698c1f833a1fdc1fe0cb392d825ad484c71b0d84388ac80bfd3d6079',
172-
'size_bytes': 43716484,
173-
'generation': 1711567575687220,
170+
'object_name': 'fa98c6432de572206bc5519f85e9c96bd518b039',
171+
'sha256sum': 'fb563633b5bfe2d4307075c54c6bb54664a3b5ec6bc811f5b15742720549007a',
172+
'size_bytes': 50288755,
173+
'generation': 1730835522207929,
174174
'output_file': 'node-linux-x64.tar.gz',
175175
},
176176
],
@@ -181,10 +181,10 @@ deps = {
181181
'bucket': 'chromium-nodejs',
182182
'objects': [
183183
{
184-
'object_name': '20.11.0/e3c0fd53caae857309815f3f8de7c2dce49d7bca',
185-
'sha256sum': '20affacca2480c368b75a1d91ec1a2720604b325207ef0cf39cfef3c235dad19',
186-
'size_bytes': 40649378,
187-
'generation': 1711567481181885,
184+
'object_name': '4c8952a65a1ce7a2e4cff6db68f9b7454c46349f',
185+
'sha256sum': 'fadb4530fbe6e35ed298848c66102a0aa7d92974789e6222c4eadee26a381e7e',
186+
'size_bytes': 45672893,
187+
'generation': 1730835514382259,
188188
'output_file': 'node-darwin-x64.tar.gz',
189189
},
190190
],
@@ -195,10 +195,10 @@ deps = {
195195
'bucket': 'chromium-nodejs',
196196
'objects': [
197197
{
198-
'object_name': '20.11.0/5b5681e12a21cda986410f69e03e6220a21dd4d2',
199-
'sha256sum': 'cecb99fbb369a9090dddc27e228b66335cd72555b44fa8839ef78e56c51682c5',
200-
'size_bytes': 38989321,
201-
'generation': 1711567557161126,
198+
'object_name': '0886aa6a146cb5c213cb09b59ed1075982e4cb57',
199+
'sha256sum': 'd39e2d44d58bb89740b9aca1073959fc92edbdbbe810a5e48448e331cf72c196',
200+
'size_bytes': 44929037,
201+
'generation': 1730835518292126,
202202
'output_file': 'node-darwin-arm64.tar.gz',
203203
},
204204
],
@@ -209,10 +209,10 @@ deps = {
209209
'bucket': 'chromium-nodejs',
210210
'objects': [
211211
{
212-
'object_name': '20.11.0/2cb36010af52bc5e2a2d1e3675c10361c80d8f8d',
213-
'sha256sum': '5da5e201155bb3ea99134b404180adebcfa696b0dbc09571d01a09ca5489f53e',
214-
'size_bytes': 70017688,
215-
'generation': 1705443750949255,
212+
'object_name': '907d7e104e7389dc74cec7d32527c1db704b7f96',
213+
'sha256sum': '7447c4ece014aa41fb2ff866c993c708e5a8213a00913cc2ac5049ea3ffc230d',
214+
'size_bytes': 80511640,
215+
'generation': 1730835526374028,
216216
'output_file': 'node.exe',
217217
},
218218
],

PRESUBMIT.py

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -179,33 +179,10 @@ def _CheckFormat(input_api, output_api):
179179
'Non-git environment detected, skipping _CheckFormat.')
180180
]
181181

182-
files_with_potential_large_diffs = _getAffectedFiles(
183-
input_api, [
184-
input_api.os_path.join(input_api.PresubmitLocalPath(),
185-
'node_modules'),
186-
input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end',
187-
'third_party'),
188-
input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end',
189-
'generated'),
190-
input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end',
191-
'models', 'javascript_metadata'),
192-
], [], [])
193-
194-
# Changes to the above directories can produce large diffs. This is a problem on Windows,
195-
# where clang-format-diff.py specifies all the diff ranges on the command line when invoking
196-
# clang-format. Since command line length is limited on Win, the invocation fails.
197-
# As a heuristic, we'll format all touched files fully if we suspect that the diff could
198-
# be large.
199-
# TODO(crbug.com/1068198): Remove once `git cl format --js` can handle large CLs.
200-
additional_args = []
201-
if (len(files_with_potential_large_diffs) > 0):
202-
additional_args = ['--full']
203-
204182
results = [output_api.PresubmitNotifyResult('Running Format Checks:')]
205183

206184
return _ExecuteSubProcess(input_api, output_api,
207-
['git', 'cl', 'format', '--js'] +
208-
additional_args, [], results)
185+
['git', 'cl', 'format', '--js'], [], results)
209186

210187

211188
def _CheckDevToolsRunESLintTests(input_api, output_api):
@@ -232,7 +209,7 @@ def _CheckDevToolsRunESLintTests(input_api, output_api):
232209

233210
mocha_path = devtools_paths.mocha_path()
234211
eslint_tests_path = input_api.os_path.join(eslint_rules_dir_path, 'tests',
235-
'*_test.js')
212+
'*.test.js')
236213

237214
results = [output_api.PresubmitNotifyResult('ESLint rules unit tests')]
238215
results.extend(

build_overrides/build.gni

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,15 @@ build_with_chromium = false
1010
ignore_elf32_limitations = true
1111

1212
use_system_xcode = true
13+
14+
# Enables assertions on safety checks in libc++.
15+
#
16+
# This should be set to true whenever building with Chrome's custom libc++ in
17+
# order to guard against undefined behavior. However, the asserts added by
18+
# hardening libc++ may introduce some performance overhead, so this is
19+
# configurable to simplify A/B tests, and to allow performance-sensitive
20+
# projects embedding Chrome (e.g. ANGLE) to disable libc++ hardening.
21+
#
22+
# Note that setting this to true only has an effect when also building with
23+
# `use_custom_libcxx = true`.
24+
enable_safe_libcxx = true

0 commit comments

Comments
 (0)