Skip to content

Commit 880f32d

Browse files
haargbingos
authored andcommitted
remove use vars from non-bundled modules
1 parent 93a2187 commit 880f32d

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lib/ExtUtils/Command.pm

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ use 5.00503;
44
use strict;
55
use warnings;
66
require Exporter;
7-
use vars qw(@ISA @EXPORT @EXPORT_OK $VERSION);
8-
@ISA = qw(Exporter);
9-
@EXPORT = qw(cp rm_f rm_rf mv cat eqtime mkpath touch test_f test_d chmod
10-
dos2unix);
11-
$VERSION = '7.67_01';
7+
our @ISA = qw(Exporter);
8+
our @EXPORT = qw(cp rm_f rm_rf mv cat eqtime mkpath touch test_f test_d chmod
9+
dos2unix);
10+
our $VERSION = '7.67_01';
1211
$VERSION =~ tr/_//d;
1312

1413
my $Is_VMS = $^O eq 'VMS';

lib/ExtUtils/MM_Unix.pm

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ our %Config_Override;
1313

1414
use ExtUtils::MakeMaker qw($Verbose neatvalue _sprintf562);
1515

16-
# If we make $VERSION an our variable parse_version() breaks
17-
use vars qw($VERSION);
18-
$VERSION = '7.67_01';
16+
# If $VERSION is in scope, parse_version() breaks
17+
{
18+
our $VERSION = '7.67_01';
1919
$VERSION =~ tr/_//d;
20+
}
2021

2122
require ExtUtils::MM_Any;
2223
our @ISA = qw(ExtUtils::MM_Any);
@@ -2196,7 +2197,7 @@ Add MM_Unix_VERSION.
21962197
sub init_platform {
21972198
my($self) = shift;
21982199

2199-
$self->{MM_Unix_VERSION} = $VERSION;
2200+
$self->{MM_Unix_VERSION} = our $VERSION;
22002201
$self->{PERL_MALLOC_DEF} = '-DPERL_EXTMALLOC_DEF -Dmalloc=Perl_malloc '.
22012202
'-Dfree=Perl_mfree -Drealloc=Perl_realloc '.
22022203
'-Dcalloc=Perl_calloc';

0 commit comments

Comments
 (0)