Skip to content

Commit fead8dc

Browse files
iabynmohawk2
authored andcommitted
EU::MakeMaker: reduce clutter on STDERR
Don't output to STDERR the message 'Processing hints file foo', as STDERR should be reserved for warnings and errors. Instead, sent it to STDOUT - and even then, only with $Verbose, as otherwise it appears as spurious output when running t/hints.t
1 parent 172ec69 commit fead8dc

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/ExtUtils/MakeMaker.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,7 @@ sub _run_hintfile {
11111111
my($hint_file) = shift;
11121112

11131113
local($@, $!);
1114-
warn "Processing hints file $hint_file\n";
1114+
print "Processing hints file $hint_file\n" if $Verbose;
11151115

11161116
# Just in case the ./ isn't on the hint file, which File::Spec can
11171117
# often strip off, we bung the curdir into @INC

t/hints.t

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ CLOO
4242

4343
$mm->check_hints;
4444
is( $mm->{CCFLAGS}, 'basset hounds got long ears' );
45-
is( $stderr, "Processing hints file $Hint_File\n" );
45+
is( $stderr, "" );
4646
}
4747

4848

@@ -62,7 +62,6 @@ CLOO
6262

6363
$mm->check_hints;
6464
is( $stderr, <<OUT, 'hint files produce errors' );
65-
Processing hints file $Hint_File
6665
Argh!
6766
OUT
6867
}

0 commit comments

Comments
 (0)