PodParser now respects =encoding directives

When deriving authors or abstract from pod, if encoding is ignored the
related META files will then be incorrect.

This implementation makes reading the pod two pass, first to find an
=encoding directive if it exists and if so set the binmode, then seeks
back to the top to continue parsing as usual.

To support this I have also moved away from testing with a tied class,
which was then mocking out everything that was attempting to be tested.
It now simply uses open to a string.

Author: jberger

lib/Module/Build/PodParser.pm

@@ -24,6 +24,13 @@ sub parse_from_filehandle {
   my ($self, $fh) = @_;
 
   local $_;
+  while (<$fh>) {
+    next unless /=encoding \s+ (.*)/ix;
+    binmode $fh, ":encoding($1)";
+    last;
+  }
+  seek $fh, 0, 0;
+
   while (<$fh>) {
     next unless /^=(?!cut)/ .. /^=cut/;  # in POD
     # Accept Name - abstract or C<Name> - abstract

t/pod_parser.t

@@ -2,29 +2,16 @@
 
 use strict;
 use lib 't/lib';
-use MBTest tests => 14;
+use MBTest tests => 16;
+
+use Encode 'encode';
 
 blib_load('Module::Build::PodParser');
 
 #########################
 
 {
-  package IO::StringBased;
-
-  sub TIEHANDLE {
-    my ($class, $string) = @_;
-    return bless {
-		  data => [ map "$_\n", split /\n/, $string],
-		 }, $class;
-  }
-
-  sub READLINE {
-    shift @{ shift()->{data} };
-  }
-}
-
-local *FH;
-tie *FH, 'IO::StringBased', <<'EOF';
+open my $fh, '<', \<<'EOF';
 =head1 NAME
 
 Foo::Bar - Perl extension for blah blah blah
@@ -39,25 +26,24 @@ Home page: http://example.com/~eh/
 EOF
 
 
-my $pp = Module::Build::PodParser->new(fh => \*FH);
+my $pp = Module::Build::PodParser->new(fh => $fh);
 ok $pp, 'object created';
 
 is $pp->get_author->[0], 'C<Foo::Bar> was written by Engelbert Humperdinck I<E<lt>[email protected]<gt>> in 2004.', 'author';
 is $pp->get_abstract, 'Perl extension for blah blah blah', 'abstract';
-
+}
 
 {
   # Try again without a valid author spec
-  untie *FH;
-  tie *FH, 'IO::StringBased', <<'EOF';
+open my $fh, '<', \<<'EOF';
 =head1 NAME
 
 Foo::Bar - Perl extension for blah blah blah
 
 =cut
 EOF
 
-  my $pp = Module::Build::PodParser->new(fh => \*FH);
+  my $pp = Module::Build::PodParser->new(fh => $fh);
   ok $pp, 'object created';
 
   is_deeply $pp->get_author, [], 'author';
@@ -67,8 +53,7 @@ EOF
 
 {
     # Try again with mixed-case =head1s.
-  untie *FH;
-  tie *FH, 'IO::StringBased', <<'EOF';
+open my $fh, '<', \<<'EOF';
 =head1 Name
 
 Foo::Bar - Perl extension for blah blah blah
@@ -82,7 +67,7 @@ Home page: http://example.com/~eh/
 =cut
 EOF
 
-  my $pp = Module::Build::PodParser->new(fh => \*FH);
+  my $pp = Module::Build::PodParser->new(fh => $fh);
   ok $pp, 'object created';
 
   is $pp->get_author->[0], 'C<Foo::Bar> was written by Engelbert Humperdinck I<E<lt>[email protected]<gt>> in 2004.', 'author';
@@ -92,8 +77,7 @@ EOF
 
 {
     # Now with C<Module::Name>
-  untie *FH;
-  tie *FH, 'IO::StringBased', <<'EOF';
+open my $fh, '<', \<<'EOF';
 =head1 Name
 
 C<Foo::Bar> - Perl extension for blah blah blah
@@ -107,16 +91,15 @@ Home page: http://example.com/~eh/
 =cut
 EOF
 
-  my $pp = Module::Build::PodParser->new(fh => \*FH);
+  my $pp = Module::Build::PodParser->new(fh => $fh);
   ok $pp, 'object created';
 
   is $pp->get_author->[0], 'C<Foo::Bar> was written by Engelbert Humperdinck I<E<lt>[email protected]<gt>> in 2004.', 'author';
   is $pp->get_abstract, 'Perl extension for blah blah blah', 'abstract';
 }
 
 {
-local *FH;
-tie *FH, 'IO::StringBased', <<'EOF';
+open my $fh, '<', \<<'EOF';
 =head1 NAME
 
 Foo_Bar - Perl extension for eating pie
@@ -131,7 +114,29 @@ Home page: http://example.com/~eh/
 EOF
 
 
-  my $pp = Module::Build::PodParser->new(fh => \*FH);
+  my $pp = Module::Build::PodParser->new(fh => $fh);
   ok $pp, 'object created';
   is $pp->get_abstract, 'Perl extension for eating pie', 'abstract';
 }
+
+{
+  open my $fh, '<', \ encode 'UTF-8', <<"EOF";
+=encoding utf8
+
+=head1 NAME
+
+Foo_Bar - I \x{2764} Perl
+
+=head1 AUTHOR
+
+C<Foo_Bar> was written by Engelbert Humperdinck I<E<lt>eh\@example.comE<gt>> in 2004.
+
+Home page: http://example.com/~eh/
+
+=cut
+EOF
+
+  my $pp = Module::Build::PodParser->new(fh => $fh);
+  ok $pp, 'object created';
+  is $pp->get_abstract, "I \x{2764} Perl", 'abstract with unicode';
+}