Skip to content

Commit 7f15575

Browse files
Ovidrjbs
authored andcommitted
Be explicit that returning false will fail to load the module.
1 parent 20d3ae8 commit 7f15575

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

rfcs/rfcOVID-0018.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,10 @@ side-effect.
3232

3333
Code using the above does not need to return a magic true value when compiled.
3434

35-
If the module explicitly returns a false value, we should consider if this can
36-
be ignored (I suspect this is usually a bug). However, the module author
37-
_might_ have conditional logic to explicitly return a false value in case
38-
there's a missing dependency (or for some other reason). Discussion might be
39-
useful here.
35+
If the module explicitly returns a false value, module loading will fail as it
36+
does now. If the module author wants the module to fail to load under certain
37+
conditions, they should die with an appropriate error message rather than
38+
returning false.
4039

4140
## Backwards Compatibility
4241

0 commit comments

Comments
 (0)