Skip to content

Commit 9516647

Browse files
committed
Might as well supply the (a?) target SV when operating on lexical targets
1 parent 87fb47c commit 9516647

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ppcs/ppcTODO-attributes-v2.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ It may make sense to have two different callbacks, one for GV-named targets and
184184
struct PerlAttributeDefinition
185185
{
186186
...
187-
void (*apply_pkg)(pTHX_ SV *target, GV *targetname, SV *attrvalue, void *data);
188-
void (*apply_lex)(pTHX_ PADOFFSET targetix, SV *attrvalue, void *data);
187+
void (*apply_pkg)(pTHX_ SV *target, GV *namegv, SV *attrvalue, void *data);
188+
void (*apply_lex)(pTHX_ SV *target, PADOFFSET padix, SV *attrvalue, void *data);
189189
};
190190
```
191191

@@ -198,8 +198,8 @@ enum PerlAttributeTargetKind {
198198
};
199199

200200
union PerlAttributeTarget {
201-
struct { SV *sv; GV *namegv; } pkgscoped;
202-
struct { PADOFFSET padix; } lexical;
201+
struct { SV *sv; GV *namegv; } pkgscoped;
202+
struct { SV *sv; PADOFFSET padix; } lexical;
203203
};
204204

205205
struct PerlAttributeDefinition

0 commit comments

Comments
 (0)