Skip to content

Commit 1db3d71

Browse files
committed
As suggested get rid of the 'v*' to match official Perl images
Better to do it early in the process before people start using it.
1 parent cda9d4f commit 1db3d71

File tree

2 files changed

+24
-17
lines changed

2 files changed

+24
-17
lines changed

.github/workflows/publish-to-docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ jobs:
3939
password: ${{ secrets.DOCKER_GITHUB_TOKEN }}
4040
dockerfile: Dockerfile
4141
buildargs: BASE=${{ matrix.perl-version }}
42-
tags: "v${{ matrix.perl-version }}"
42+
tags: "${{ matrix.perl-version }}"

README.md

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ This repo is used to build Perl Docker images with various pre-installed bits:
99
* various testing modules
1010
* Dist::Zilla with some common plugins (for Perl >= 5.14)
1111

12+
At this points images are refreshed daily, which could change overtime if it becomes an issue.
13+
This should guarantee you to test uptodate CPAN stack.
14+
15+
Note: if one dependency fails to install, this should not impact you as the image would not be published
16+
on failures.
17+
1218
# List of Perl modules
1319

1420
## Available on all Perl Versions
@@ -67,18 +73,18 @@ The images can be found at [https://hub.docker.com/repository/docker/perldocker/
6773
The following tags are available from the repository `perldocker/perl-tester`
6874

6975
```
70-
v5.30
71-
v5.28
72-
v5.26
73-
v5.24
74-
v5.22
75-
v5.20
76-
v5.18
77-
v5.16
78-
v5.14
79-
v5.12
80-
v5.10
81-
v5.8
76+
5.30
77+
5.28
78+
5.26
79+
5.24
80+
5.22
81+
5.20
82+
5.18
83+
5.16
84+
5.14
85+
5.12
86+
5.10
87+
5.8
8288
```
8389

8490
# Continuous Integrations
@@ -131,7 +137,7 @@ jobs:
131137
- '5.8'
132138
133139
container:
134-
image: perldocker/perl-tester:v${{ matrix.perl-version }}
140+
image: perldocker/perl-tester:${{ matrix.perl-version }}
135141
136142
steps:
137143
- uses: actions/checkout@v1
@@ -145,14 +151,14 @@ jobs:
145151
run: make test
146152
```
147153

148-
...
154+
You can find more details on how to setup GitHub workflow to smoke Perl projects by reading [skaji/perl-github-actions-sample](https://github.com/skaji/perl-github-actions-sample) GitHub repository.
149155

150156
## Building Docker images
151157

152158
When pushing to GitHub, it's using a GitHub action `.github/workflows/publish-to-docker.yml`
153159
to automagically build and publish the docker images for you.
154160

155-
If you consider cloning this repository, you wouldhave to set in your GitHub repository the following secret variables, with some example values.
161+
If you consider cloning this repository, you would have to set in your GitHub repository the following secret variables, with some example values.
156162

157163
```
158164
DOCKER_REPO=perldocker/perl-tester
@@ -162,4 +168,5 @@ DOCKER_GITHUB_TOKEN=a-token-or-password
162168

163169
# Author
164170

165-
Oalders initiated the project and atoomic tried to give it more public visibility.
171+
@oalders initiated the project and @atoomic tried to give it more public visibility
172+
volunteers/ideas are welcome to improve the project.

0 commit comments

Comments
 (0)