isUTF8_CHAR: Declare variable to be U16, not UV

khwilliamson · khwilliamson · commit 012637a28282 · 2024-10-31T12:15:15.000-06:00
The data here only needs 8 bits on ASCII platforms; 9 on EBCDIC.
Using fast U16 works for both.  I don't think it's worth an #ifdef.

f
diff --git a/inline.h b/inline.h
@@ -2244,7 +2244,7 @@ Perl_is_utf8_string_loclen(const U8 *s, STRLEN len, const U8 **ep, STRLEN *el)
     STMT_START {                                                            \
         const U8 * s8dfa_ = s0;                                             \
         const U8 * const e8dfa_ = e;                                        \
-        UV state = 0;                                                       \
+        PERL_UINT_FAST16_T state = 0;                                        \
                                                                             \
         PERL_NON_CORE_CHECK_EMPTY(s8dfa_, e8dfa_);                          \
                                                                             \

Original file line number	Diff line number	Diff line change
`@@ -2244,7 +2244,7 @@ Perl_is_utf8_string_loclen(const U8 s, STRLEN len, const U8 ep, STRLEN el)`
`2244`	`2244`	`STMT_START { \`
`2245`	`2245`	`const U8 * s8dfa_ = s0; \`
`2246`	`2246`	`const U8 * const e8dfa_ = e; \`
`2247`		`- UV state = 0; \`
	`2247`	`+ PERL_UINT_FAST16_T state = 0; \`
`2248`	`2248`	`\`
`2249`	`2249`	`PERL_NON_CORE_CHECK_EMPTY(s8dfa_, e8dfa_); \`
`2250`	`2250`	`\`