Dont call Perl_croak manually in core

Just call croak instead, we've been able to do that for vararg functions
since d933027

Author: Leont

av.c

@@ -99,7 +99,7 @@ Perl_av_extend_guts(pTHX_ AV *av, SSize_t key, SSize_t *maxp, SV ***allocp,
     PERL_ARGS_ASSERT_AV_EXTEND_GUTS;
 
     if (key < -1) /* -1 is legal */
-        Perl_croak(aTHX_
+        croak(
             "panic: av_extend_guts() negative count (%" IVdf ")", (IV)key);
 
     if (key > *maxp) {

builtin.c

@@ -308,19 +308,19 @@ XS(XS_builtin_export_lexically)
     warn_experimental_builtin("export_lexically");
 
     if(!PL_compcv)
-        Perl_croak(aTHX_
+        croak(
                 "export_lexically can only be called at compile time");
 
     if(items % 2)
-        Perl_croak(aTHX_ "Odd number of elements in export_lexically");
+        croak("Odd number of elements in export_lexically");
 
     for(int i = 0; i < items; i += 2) {
         SV *name = ST(i);
         SV *ref  = ST(i+1);
 
         if(!SvROK(ref))
             /* diag_listed_as: Expected %s reference in export_lexically */
-            Perl_croak(aTHX_ "Expected a reference in export_lexically");
+            croak("Expected a reference in export_lexically");
 
         char sigil = SvPVX(name)[0];
         SV *rv = SvRV(ref);
@@ -358,7 +358,7 @@ XS(XS_builtin_export_lexically)
         }
 
         if(bad)
-            Perl_croak(aTHX_ "Expected %s reference in export_lexically", bad);
+            croak("Expected %s reference in export_lexically", bad);
     }
 
     prepare_export_lexical();
@@ -695,7 +695,7 @@ static void S_import_sym(pTHX_ SV *sym)
 
     CV *cv = get_cv(SvPV_nolen(fqname), SvUTF8(fqname) ? SVf_UTF8 : 0);
     if(!cv)
-        Perl_croak(aTHX_ builtin_not_recognised, sym);
+        croak(builtin_not_recognised, sym);
 
     export_lexical(ampname, (SV *)cv);
 }
@@ -737,7 +737,7 @@ XS(XS_builtin_import)
     dXSARGS;
 
     if(!PL_compcv)
-        Perl_croak(aTHX_
+        croak(
                 "builtin::import can only be called at compile time");
 
     prepare_export_lexical();
@@ -747,19 +747,19 @@ XS(XS_builtin_import)
         STRLEN symlen;
         const char *sympv = SvPV(sym, symlen);
         if(strEQ(sympv, "import"))
-            Perl_croak(aTHX_ builtin_not_recognised, sym);
+            croak(builtin_not_recognised, sym);
 
         if(sympv[0] == ':') {
             UV vmajor, vminor;
             if(!S_parse_version(sympv + 1, sympv + symlen, &vmajor, &vminor))
-                Perl_croak(aTHX_ "Invalid version bundle %" SVf_QUOTEDPREFIX, sym);
+                croak("Invalid version bundle %" SVf_QUOTEDPREFIX, sym);
 
             U16 want_ver = SHORTVER(vmajor, vminor);
 
             if(want_ver < SHORTVER(5,39) ||
                     /* round up devel version to next major release; e.g. 5.39 => 5.40 */
                     want_ver > SHORTVER(PERL_REVISION, PERL_VERSION + (PERL_VERSION % 2)))
-                Perl_croak(aTHX_ "Builtin version bundle \"%s\" is not supported by Perl " PERL_VERSION_STRING,
+                croak("Builtin version bundle \"%s\" is not supported by Perl " PERL_VERSION_STRING,
                         sympv);
 
             import_builtin_bundle(want_ver);

class.c

@@ -145,7 +145,7 @@ XS(injected_constructor)
                 HvNAMEfARG(stash));
 
     if (!aux->xhv_class_initfields_cv) {
-        Perl_croak(aTHX_ "Cannot create an object of incomplete class %" HvNAMEf_QUOTEDPREFIX,
+        croak("Cannot create an object of incomplete class %" HvNAMEf_QUOTEDPREFIX,
                    HvNAMEfARG(stash));
     }
 

cygwin/cygwin.c

@@ -217,7 +217,7 @@ XS(Cygwin_cwd)
        There is Cwd->cwd() usage in the wild, and previous versions didn't die.
      */
     if(items > 1)
-        Perl_croak(aTHX_ "Usage: Cwd::cwd()");
+        croak("Usage: Cwd::cwd()");
     if((cwd = getcwd(NULL, -1))) {
         ST(0) = sv_2mortal(newSVpv(cwd, 0));
         free(cwd);
@@ -234,7 +234,7 @@ XS(XS_Cygwin_pid_to_winpid)
     pid_t pid, RETVAL;
 
     if (items != 1)
-        Perl_croak(aTHX_ "Usage: Cygwin::pid_to_winpid(pid)");
+        croak("Usage: Cygwin::pid_to_winpid(pid)");
 
     pid = (pid_t)SvIV(ST(0));
 
@@ -252,7 +252,7 @@ XS(XS_Cygwin_winpid_to_pid)
     pid_t pid, RETVAL;
 
     if (items != 1)
-        Perl_croak(aTHX_ "Usage: Cygwin::winpid_to_pid(pid)");
+        croak("Usage: Cygwin::winpid_to_pid(pid)");
 
     pid = (pid_t)SvIV(ST(0));
 
@@ -293,15 +293,15 @@ S_convert_path_common(pTHX_ const direction_t direction)
         const char *name = (direction == to_posix)
                      ? "win::win_to_posix_path"
                      : "posix_to_win_path";
-        Perl_croak(aTHX_ "Usage: Cygwin::%s(pathname, [absolute])", name);
+        croak("Usage: Cygwin::%s(pathname, [absolute])", name);
     }
 
     src_path = SvPVx(ST(0), len);
     if (items == 2)
         absolute_flag = SvTRUE(ST(1));
 
     if (!len)
-        Perl_croak(aTHX_ "can't convert empty path");
+        croak("can't convert empty path");
     isutf8 = SvUTF8(ST(0));
 
 #if HAVE_CYGWIN_VERSION(0, 181)
@@ -411,7 +411,7 @@ XS(XS_Cygwin_mount_table)
     struct mntent *mnt;
 
     if (items != 0)
-        Perl_croak(aTHX_ "Usage: Cygwin::mount_table");
+        croak("Usage: Cygwin::mount_table");
     /* => array of [mnt_dir mnt_fsname mnt_type mnt_opts] */
 
     setmntent (0, 0);
@@ -435,7 +435,7 @@ XS(XS_Cygwin_mount_flags)
     flags[0] = '\0';
 
     if (items != 1)
-        Perl_croak(aTHX_ "Usage: Cygwin::mount_flags( mnt_dir | '/cygdrive' )");
+        croak("Usage: Cygwin::mount_flags( mnt_dir | '/cygdrive' )");
 
     pathname = SvPV_nolen(ST(0));
 
@@ -513,7 +513,7 @@ XS(XS_Cygwin_is_binmount)
     char *pathname;
 
     if (items != 1)
-        Perl_croak(aTHX_ "Usage: Cygwin::is_binmount(pathname)");
+        croak("Usage: Cygwin::is_binmount(pathname)");
 
     pathname = SvPV_nolen(ST(0));