Remove mathoms.c stub Perl_is_utf8_string_loc

khwilliamson · khwilliamson · commit 0d6c2e8ca41e · 2024-10-28T09:55:09.000-06:00
This is now implemented entirely via macros
diff --git a/embed.fnc b/embed.fnc
@@ -1740,7 +1740,7 @@ ARTdip	|bool	|is_utf8_string_flags					\
 				|NN const U8 *s 			\
 				|STRLEN len				\
 				|const U32 flags
-AMTbdp	|bool	|is_utf8_string_loc					\
+ATdmp	|bool	|is_utf8_string_loc					\
 				|NN const U8 *s 			\
 				|const STRLEN len			\
 				|NN const U8 **ep
diff --git a/embed.h b/embed.h
@@ -322,6 +322,7 @@
 # define is_utf8_fixed_width_buf_loclen_flags   Perl_is_utf8_fixed_width_buf_loclen_flags
 # define is_utf8_invariant_string_loc           Perl_is_utf8_invariant_string_loc
 # define is_utf8_string_flags                   Perl_is_utf8_string_flags
+# define is_utf8_string_loc                     Perl_is_utf8_string_loc
 # define is_utf8_string_loclen                  Perl_is_utf8_string_loclen
 # define is_utf8_string_loclen_flags            Perl_is_utf8_string_loclen_flags
 # define is_utf8_valid_partial_char_flags       Perl_is_utf8_valid_partial_char_flags
diff --git a/inline.h b/inline.h
@@ -2114,7 +2114,8 @@ Perl_is_utf8_string_flags(const U8 *s, STRLEN len, const U32 flags)
     return TRUE;
 }
 
-#define is_utf8_string_loc(s, len, ep)  is_utf8_string_loclen(s, len, ep, 0)
+#define Perl_is_utf8_string_loc(s, len, ep)          \
+        Perl_is_utf8_string_loclen(s, len, ep, 0)
 
 PERL_STATIC_INLINE bool
 Perl_is_utf8_string_loclen(const U8 *s, STRLEN len, const U8 **ep, STRLEN *el)
diff --git a/mathoms.c b/mathoms.c
@@ -437,14 +437,6 @@ Perl_do_aexec(pTHX_ SV *really, SV **mark, SV **sp)
 }
 #endif
 
-bool
-Perl_is_utf8_string_loc(const U8 *s, const STRLEN len, const U8 **ep)
-{
-    PERL_ARGS_ASSERT_IS_UTF8_STRING_LOC;
-
-    return is_utf8_string_loclen(s, len, ep, 0);
-}
-
 /*
 =for apidoc_section $SV
 =for apidoc sv_nolocking
diff --git a/proto.h b/proto.h

Original file line number	Diff line number	Diff line change
`@@ -2114,7 +2114,8 @@ Perl_is_utf8_string_flags(const U8 *s, STRLEN len, const U32 flags)`
`2114`	`2114`	`return TRUE;`
`2115`	`2115`	`}`
`2116`	`2116`
`2117`		`-#define is_utf8_string_loc(s, len, ep) is_utf8_string_loclen(s, len, ep, 0)`
	`2117`	`+#define Perl_is_utf8_string_loc(s, len, ep) \`
	`2118`	`+ Perl_is_utf8_string_loclen(s, len, ep, 0)`
`2118`	`2119`
`2119`	`2120`	`PERL_STATIC_INLINE bool`
`2120`	`2121`	`Perl_is_utf8_string_loclen(const U8 s, STRLEN len, const U8 ep, STRLEN el)`