Make Perl_sv_setsv a macro and rm from mathoms

93f23f0 made the Perl_ name generation
automatic given the flags in embed.fnc.

This function behaves differently when called from core than not, but
making it into a macro that gets expanded as needed means it
automatically gets expanded correctly.

Author: khwilliamson

embed.fnc

@@ -3454,7 +3454,7 @@ Adp	|void	|sv_setrv_noinc |NN SV * const sv			\
 Adp	|void	|sv_setrv_noinc_mg					\
 				|NN SV * const sv			\
 				|NN SV * const ref
-AMbdp	|void	|sv_setsv	|NN SV *dsv				\
+Admp	|void	|sv_setsv	|NN SV *dsv				\
 				|NULLOK SV *ssv
 Adp	|void	|sv_setsv_flags |NN SV *dsv				\
 				|NULLOK SV *ssv 			\

embed.h

@@ -2315,6 +2315,7 @@
 #   define Perl_sv_insert(mTHX,a,b,c,d,e)       sv_insert(a,b,c,d,e)
 #   define Perl_sv_mortalcopy(mTHX,a)           sv_mortalcopy(a)
 #   define Perl_sv_pvn_force(mTHX,a,b)          sv_pvn_force(a,b)
+#   define Perl_sv_setsv(mTHX,a,b)              sv_setsv(a,b)
 #   define Perl_sv_taint(mTHX,a)                sv_taint(a)
 #   define Perl_sv_unref(mTHX,a)                sv_unref(a)
 #   define Perl_sv_usepvn(mTHX,a,b,c)           sv_usepvn(a,b,c)
@@ -2369,6 +2370,7 @@
 #   define Perl_sv_insert                       sv_insert
 #   define Perl_sv_mortalcopy                   sv_mortalcopy
 #   define Perl_sv_pvn_force                    sv_pvn_force
+#   define Perl_sv_setsv                        sv_setsv
 #   define Perl_sv_taint                        sv_taint
 #   define Perl_sv_unref                        sv_unref
 #   define Perl_sv_usepvn                       sv_usepvn

mathoms.c

@@ -82,18 +82,6 @@ Perl_ref(pTHX_ OP *o, I32 type)
     return doref(o, type, TRUE);
 }
 
-/* sv_setsv() is now a macro using Perl_sv_setsv_flags();
- * this function provided for binary compatibility only
- */
-
-void
-Perl_sv_setsv(pTHX_ SV *dsv, SV *ssv)
-{
-    PERL_ARGS_ASSERT_SV_SETSV;
-
-    sv_setsv_flags(dsv, ssv, SV_GMAGIC);
-}
-
 /*
 =for apidoc_section $SV
 =for apidoc sv_pv