regen/embed.pl: Skip unnecessary code

khwilliamson · khwilliamson · commit 2393e60769c3 · 2025-08-08T08:26:02.000-06:00
If an argument is a literal string, it's not going to be anything else,
so convert an elsif to an else.
diff --git a/regen/embed.pl b/regen/embed.pl
@@ -254,7 +254,8 @@ sub generate_proto_h {
                     die_at_end 'm flag required for "literal" argument'
                                                             unless $has_mflag;
                 }
-                elsif (   $args_assert_line
+                else {
+                   if (   $args_assert_line
                        && $arg =~ /\*/
                        && $arg !~ /\b(NN|NULLOK)\b/ )
                 {
@@ -298,6 +299,7 @@ sub generate_proto_h {
                         push @asserts, "assert($type_assert)";
                     }
                 }
+                }
             }
             $ret .= join ", ", @$args;
         }

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,8 @@ sub generate_proto_h {`
`254`	`254`	`die_at_end 'm flag required for "literal" argument'`
`255`	`255`	`unless $has_mflag;`
`256`	`256`	`}`
`257`		`- elsif ( $args_assert_line`
	`257`	`+ else {`
	`258`	`+ if ( $args_assert_line`
`258`	`259`	`&& $arg =~ /\*/`
`259`	`260`	`&& $arg !~ /\b(NN\|NULLOK)\b/ )`
`260`	`261`	`{`
`@@ -298,6 +299,7 @@ sub generate_proto_h {`
`298`	`299`	`push @asserts, "assert($type_assert)";`
`299`	`300`	`}`
`300`	`301`	`}`
	`302`	`+ }`
`301`	`303`	`}`
`302`	`304`	`$ret .= join ", ", @$args;`
`303`	`305`	`}`