Skip to content

Commit 4623583

Browse files
committed
XS-APItest/t/utf8.t: Tidy
Clarify comment and note() and vertically align a table
1 parent f2cb455 commit 4623583

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

ext/XS-APItest/t/utf8.t

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,33 +1188,33 @@ SKIP:
11881188
# of bytes on ASCII and EBCDIC: 5
11891189
utf8::encode($utf_ch);
11901190
my $utf_ch_len = length $utf_ch;
1191-
note "utf_ch_len $utf_ch_len";
1191+
note "bytes in each \$utf_ch $utf_ch_len";
11921192
my $utf = $utf_ch x 10;
11931193
my $bad_start = substr($utf, 1);
11941194
# $bad_end ends with a start byte and a single continuation
11951195
my $bad_end = substr($utf, 0, length($utf)-$utf_ch_len+2);
11961196

11971197
my @hop_tests =
1198-
( # start byte chars
1199-
# string in 'string' to hop expected name
1200-
[ $simple, 0, 5, 5, "simple in range, forward" ],
1198+
( # start byte chars expected
1199+
# string in 'string' to hop new pos name
1200+
[ $simple, 0, 5, 5, "simple in range, forward" ],
12011201
[ $simple, 10, -5, 5, "simple in range, backward" ],
1202-
[ $simple, 5, 10, 10, "simple out of range, forward" ],
1203-
[ $simple, 5, -10, 0, "simple out of range, backward" ],
1204-
[ $utf, $utf_ch_len * 5, 5, length($utf), "utf in range, forward" ],
1202+
[ $simple, 5, 10, 10, "simple out of range, forward" ],
1203+
[ $simple, 5, -10, 0, "simple out of range, backward" ],
1204+
[ $utf, $utf_ch_len * 5, 5, length($utf), "utf in range, forward" ],
12051205
[ $utf, $utf_ch_len * 5, -5, 0, "utf in range, backward" ],
1206-
[ $utf, $utf_ch_len * 5, 4, $utf_ch_len * 9, "utf in range b, forward" ],
1206+
[ $utf, $utf_ch_len * 5, 4, $utf_ch_len * 9, "utf in range b, forward" ],
12071207
[ $utf, $utf_ch_len * 5, -4, $utf_ch_len, "utf in range b, backward" ],
1208-
[ $utf, $utf_ch_len * 5, 6, length($utf), "utf out of range, forward" ],
1208+
[ $utf, $utf_ch_len * 5, 6, length($utf), "utf out of range, forward" ],
12091209
[ $utf, $utf_ch_len * 5, -6, 0, "utf out of range, backward" ],
1210-
[ $bad_start, 0, 1, $utf_ch_len-1, "bad start, forward 1 from 0" ],
1211-
[ $bad_start, 0, 5, 5 * $utf_ch_len-1, "bad start, forward 5 chars from 0" ],
1210+
[ $bad_start, 0, 1, $utf_ch_len-1, "bad start, forward 1 from 0" ],
1211+
[ $bad_start, 0, 5, 5 * $utf_ch_len-1, "bad start, forward 5 chars from 0" ],
12121212
[ $bad_start, 0, 9, length($bad_start)-$utf_ch_len, "bad start, forward 9 chars from 0" ],
12131213
[ $bad_start, 0, 10, length $bad_start, "bad start, forward 10 chars from 0" ],
1214-
[ $bad_start, $utf_ch_len-1, -1, 0, "bad start, back 1 from first start byte" ],
1215-
[ $bad_start, $utf_ch_len-2, -1, 0, "bad start, back 1 from before first start byte" ],
1216-
[ $bad_start, 0, -1, 0, "bad start, back 1 from 0" ],
1217-
[ $bad_start, length $bad_start, -10, 0, "bad start, back 10 from end" ],
1214+
[ $bad_start, $utf_ch_len-1, -1, 0, "bad start, back 1 from first start byte" ],
1215+
[ $bad_start, $utf_ch_len-2, -1, 0, "bad start, back 1 from before first start byte" ],
1216+
[ $bad_start, 0, -1, 0, "bad start, back 1 from 0" ],
1217+
[ $bad_start, length $bad_start, -10, 0, "bad start, back 10 from end" ],
12181218
[ $bad_end, 0, 10, length $bad_end, "bad end, forward 10 from 0" ],
12191219
[ $bad_end, length($bad_end)-1, 10, length $bad_end, "bad end, forward 1 from end-1" ],
12201220
);

0 commit comments

Comments
 (0)