Skip to content

Commit 48f4f43

Browse files
committed
pp_aasign: silence "var set but not used" warning
PERL_RC_STACK builds were giving this warning: pp_hot.c:3147:21: warning: variable 'i' set but not used [-Wunused-but-set-variable] which was true: under that build, the i variable was being set but not used in a couple of places (it's value is only used on non-PERL_RC_STACK builds). So avoid that var under PERL_RC_STACK builds.
1 parent b60f610 commit 48f4f43

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

pp_hot.c

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3144,7 +3144,9 @@ PP(pp_aassign)
31443144
case SVt_PVHV: { /* normal hash */
31453145

31463146
SV **svp;
3147+
#ifndef PERL_RC_STACK
31473148
SSize_t i;
3149+
#endif
31483150
SSize_t nelems = lastrelem - relem + 1;
31493151
HV *hash = MUTABLE_HV(lsv);
31503152

@@ -3323,7 +3325,12 @@ PP(pp_aassign)
33233325
SV **svp;
33243326
SV **topelem = relem;
33253327

3326-
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++) {
3328+
#ifdef PERL_RC_STACK
3329+
for (svp = relem; svp <= lastrelem; svp++)
3330+
#else
3331+
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++)
3332+
#endif
3333+
{
33273334
SV *key = *svp++;
33283335
SV *val = *svp;
33293336
/* remove duplicates from list we return */
@@ -3368,7 +3375,12 @@ PP(pp_aassign)
33683375
}
33693376
else {
33703377
SV **svp;
3371-
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++) {
3378+
#ifdef PERL_RC_STACK
3379+
for (svp = relem; svp <= lastrelem; svp++)
3380+
#else
3381+
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++)
3382+
#endif
3383+
{
33723384
SV *key = *svp++;
33733385
SV *val = *svp;
33743386
#ifdef PERL_RC_STACK

0 commit comments

Comments
 (0)