Skip to content

Commit 5cafb2b

Browse files
committed
t/TEST -deparse: always list unexpected passes
't/TEST -deparse' - which uses Porting/deparse-skips.txt to decide which files are expected to fail when run after a round-trip through Deparse - normally lists any expected-fail test files which unexpectedly succeeded. However, it only lists them if at least one other test file failed. Or to put it another way, if all files expected to pass actually pass, it doesn't mention that some expected to fail passed too. This commit changes it so that it *always* lists such unexpected successes.
1 parent bed80a8 commit 5cafb2b

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

t/TEST

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -918,16 +918,6 @@ EOT
918918
print "\t$test\n";
919919
}
920920

921-
if (@unexpected_pass) {
922-
print <<EOF;
923-
924-
The following scripts were expected to fail under -deparse (at least
925-
according to $deparse_skip_file), but unexpectedly succeeded:
926-
EOF
927-
print "\t$_\n" for sort @unexpected_pass;
928-
print "\n";
929-
}
930-
931921
warn <<'SHRDLU_1';
932922
### Since not all tests were successful, you may want to run some of
933923
### them individually and examine any diagnostic messages they produce.
@@ -964,6 +954,17 @@ SHRDLU_5
964954
}
965955
}
966956
}
957+
958+
if (@unexpected_pass) {
959+
print <<EOF;
960+
961+
The following scripts were expected to fail under -deparse (at least
962+
according to $deparse_skip_file), but unexpectedly succeeded:
963+
EOF
964+
print "\t$_\n" for sort @unexpected_pass;
965+
print "\n";
966+
}
967+
967968
printf "Elapsed: %d sec\n", time() - $t0;
968969
my ($user,$sys,$cuser,$csys) = times;
969970
my $tot = sprintf("u=%.2f s=%.2f cu=%.2f cs=%.2f scripts=%d tests=%d",
@@ -991,6 +992,7 @@ SHRDLU_5
991992
}
992993
exit ($::bad_files != 0);
993994

995+
994996
# Collect platform, config data that should allow comparing
995997
# performance data between different machines. With enough data,
996998
# and/or clever statistical analysis, it should be possible to

0 commit comments

Comments
 (0)