Modernize attributes.pm for v5.40

 * use v5.40
 * `our` on package globals
 * Signatures on subs
 * Lexical subs when not required to be visible

Author: leonerd

ext/attributes/attributes.pm

@@ -1,12 +1,10 @@
-package attributes;
+package attributes 0.37;
 
-our $VERSION = 0.36;
+use v5.40;
 
-@EXPORT_OK = qw(get reftype);
-@EXPORT = ();
-%EXPORT_TAGS = (ALL => [@EXPORT, @EXPORT_OK]);
-
-use strict;
+our @EXPORT_OK = qw(get reftype);
+our @EXPORT = ();
+our %EXPORT_TAGS = (ALL => [@EXPORT, @EXPORT_OK]);
 
 sub croak {
     require Carp;
@@ -28,27 +26,24 @@ my %msg = (
     const  => 'Useless use of attribute "const"',
 );
 
-sub _modify_attrs_and_deprecate {
-    my $svtype = shift;
+my sub modify_attrs_and_deprecate ($svtype, @args) {
     # After we've removed a deprecated attribute from the XS code, we need to
     # remove it here, else it ends up in @badattrs. (If we do the deprecation in
     # XS, we can't control the warning based on *our* caller's lexical settings,
     # and the warned line is in this package)
     grep {
 	$deprecated{$svtype} && /$deprecated{$svtype}/ ? do {
-	    require warnings;
 	    warnings::warnif('deprecated', "Attribute \"$1\" is deprecated, " .
                                            "and will disappear in Perl 5.28");
 	    0;
 	} : $svtype eq 'CODE' && exists $msg{$_} ? do {
-	    require warnings;
 	    warnings::warnif(
 		'misc',
 		 $msg{$_}
 	    );
 	    0;
 	} : 1
-    } _modify_attrs(@_);
+    } _modify_attrs(@args);
 }
 
 sub import {
@@ -64,7 +59,7 @@ sub import {
 	if defined $home_stash && $home_stash ne '';
     my @badattrs;
     if ($pkgmeth) {
-	my @pkgattrs = _modify_attrs_and_deprecate($svtype, $svref, @attrs);
+	my @pkgattrs = modify_attrs_and_deprecate($svtype, $svref, @attrs);
 	@badattrs = $pkgmeth->($home_stash, $svref, @pkgattrs);
 	if (!@badattrs && @pkgattrs) {
             require warnings;
@@ -82,7 +77,7 @@ sub import {
 	}
     }
     else {
-	@badattrs = _modify_attrs_and_deprecate($svtype, $svref, @attrs);
+	@badattrs = modify_attrs_and_deprecate($svtype, $svref, @attrs);
     }
     if (@badattrs) {
 	croak "Invalid $svtype attribute" .
@@ -92,10 +87,9 @@ sub import {
     }
 }
 
-sub get ($) {
-    @_ == 1  && ref $_[0] or
+sub get ($svref) {
+    ref $svref or
 	croak 'Usage: '.__PACKAGE__.'::get $ref';
-    my $svref = shift;
     my $svtype = uc reftype($svref);
     my $stash = _guess_stash($svref);
     $stash = caller unless defined $stash;