Prefer utf8_to_bytes_overwrite to utf8_to_bytes

khwilliamson · khwilliamson · commit 71404d33b11e · 2025-01-29T06:40:17.000-07:00
The latter has never lost its experimental status
diff --git a/pp.c b/pp.c
@@ -2789,7 +2789,7 @@ S_scomplement(pTHX_ SV *targ, SV *sv)
         tmps = (U8*)SvPV_nomg(TARG, len);
 
         if (SvUTF8(TARG)) {
-            if (len && ! utf8_to_bytes(tmps, &len)) {
+            if (len && ! utf8_to_bytes_overwrite(&tmps, &len)) {
                 Perl_croak(aTHX_ FATAL_ABOVE_FF_MSG, PL_op_desc[PL_op->op_type]);
             }
             SvCUR_set(TARG, len);
diff --git a/sv.c b/sv.c
@@ -3644,7 +3644,7 @@ Perl_sv_utf8_downgrade_flags(pTHX_ SV *const sv, const bool fail_ok, const U32 f
             }
             s = (U8 *) SvPV_flags(sv, len, mg_flags);
 
-            if (!utf8_to_bytes(s, &len)) {
+            if (!utf8_to_bytes_overwrite(&s, &len)) {
                 if (fail_ok)
                     return FALSE;
                 else {

Original file line number	Diff line number	Diff line change
`@@ -2789,7 +2789,7 @@ S_scomplement(pTHX_ SV targ, SV sv)`
`2789`	`2789`	`tmps = (U8*)SvPV_nomg(TARG, len);`
`2790`	`2790`
`2791`	`2791`	`if (SvUTF8(TARG)) {`
`2792`		`- if (len && ! utf8_to_bytes(tmps, &len)) {`
	`2792`	`+ if (len && ! utf8_to_bytes_overwrite(&tmps, &len)) {`
`2793`	`2793`	`Perl_croak(aTHX_ FATAL_ABOVE_FF_MSG, PL_op_desc[PL_op->op_type]);`
`2794`	`2794`	`}`
`2795`	`2795`	`SvCUR_set(TARG, len);`
Original file line number	Diff line number	Diff line change
`@@ -3644,7 +3644,7 @@ Perl_sv_utf8_downgrade_flags(pTHX_ SV *const sv, const bool fail_ok, const U32 f`
`3644`	`3644`	`}`
`3645`	`3645`	`s = (U8 *) SvPV_flags(sv, len, mg_flags);`
`3646`	`3646`
`3647`		`- if (!utf8_to_bytes(s, &len)) {`
	`3647`	`+ if (!utf8_to_bytes_overwrite(&s, &len)) {`
`3648`	`3648`	`if (fail_ok)`
`3649`	`3649`	`return FALSE;`
`3650`	`3650`	`else {`