regen/embed.pl: Rm double negative in conditional

khwilliamson · khwilliamson · commit 8e030884953d · 2025-08-02T15:02:34.000-06:00
As suggested by Bram, this was hard to understand
diff --git a/regen/embed.pl b/regen/embed.pl
@@ -277,7 +277,11 @@ sub generate_proto_h {
                 if (!$nocheck and defined $argtype and exists $type_asserts{$argtype}) {
                     push @typed_args, [ $argtype, $argname ];
                 }
-                if (defined $argname && ($nn||$nz) && !($has_mflag && !$binarycompat)) {
+
+                if (   defined $argname
+                    && ($nn||$nz)
+                    && (! $has_mflag || $binarycompat))
+                {
                     push @names_of_nn, $argname;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,11 @@ sub generate_proto_h {`
`277`	`277`	`if (!$nocheck and defined $argtype and exists $type_asserts{$argtype}) {`
`278`	`278`	`push @typed_args, [ $argtype, $argname ];`
`279`	`279`	`}`
`280`		`- if (defined $argname && ($nn\|\|$nz) && !($has_mflag && !$binarycompat)) {`
	`280`	`+`
	`281`	`+ if ( defined $argname`
	`282`	`+ && ($nn\|\|$nz)`
	`283`	`+ && (! $has_mflag \|\| $binarycompat))`
	`284`	`+ {`
`281`	`285`	`push @names_of_nn, $argname;`
`282`	`286`	`}`
`283`	`287`	`}`