regen/embed.pl: Remove a loop

khwilliamson · khwilliamson · commit a1b80f99bd92 · 2025-08-01T08:22:41.000-06:00
By creating the @asserts array with each element in its final form, the loop that later did this can be eliminated.
diff --git a/regen/embed.pl b/regen/embed.pl
@@ -276,7 +276,7 @@ sub generate_proto_h {
 
                 if (defined $argname && (! $has_mflag || $binarycompat)) {
                     if ($nn||$nz) {
-                        push @asserts, $argname;
+                        push @asserts, "assert($argname)";
                     }
 
                     if (   ! $nocheck
@@ -286,7 +286,7 @@ sub generate_proto_h {
                         my $type_assert =
                             $type_asserts{$argtype} =~ s/__arg__/$argname/gr;
                         $type_assert = "!$argname || $type_assert" if $nullok;
-                        push @asserts, $type_assert;
+                        push @asserts, "assert($type_assert)";
                     }
                 }
             }
@@ -369,10 +369,6 @@ sub generate_proto_h {
             if (@asserts) {
                 $ret .= " \\\n";
 
-                foreach my $assertion (@asserts) {
-                    $assertion = "assert($assertion)";
-                }
-
                 my $line = "";
                 while(@asserts) {
                     my $assert = shift @asserts;

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ sub generate_proto_h {`
`276`	`276`
`277`	`277`	`if (defined $argname && (! $has_mflag \|\| $binarycompat)) {`
`278`	`278`	`if ($nn\|\|$nz) {`
`279`		`- push @asserts, $argname;`
	`279`	`+ push @asserts, "assert($argname)";`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`if ( ! $nocheck`
`@@ -286,7 +286,7 @@ sub generate_proto_h {`
`286`	`286`	`my $type_assert =`
`287`	`287`	`$type_asserts{$argtype} =~ s/__arg__/$argname/gr;`
`288`	`288`	`$type_assert = "!$argname \|\| $type_assert" if $nullok;`
`289`		`- push @asserts, $type_assert;`
	`289`	`+ push @asserts, "assert($type_assert)";`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`	`}`
`@@ -369,10 +369,6 @@ sub generate_proto_h {`
`369`	`369`	`if (@asserts) {`
`370`	`370`	`$ret .= " \\\n";`
`371`	`371`
`372`		`- foreach my $assertion (@asserts) {`
`373`		`- $assertion = "assert($assertion)";`
`374`		`- }`
`375`		`-`
`376`	`372`	`my $line = "";`
`377`	`373`	`while(@asserts) {`
`378`	`374`	`my $assert = shift @asserts;`