Skip to content

Commit bb670b1

Browse files
committed
ParseXS: tweak some code comments and indents
Make small tweaks to some of my recent work.
1 parent b25f1d3 commit bb670b1

File tree

1 file changed

+10
-9
lines changed
  • dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS

1 file changed

+10
-9
lines changed

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,10 @@ package ExtUtils::ParseXS::Node::xsub;
190190
# Process an entire XSUB definition
191191

192192
BEGIN { $build_subclass->('', # parent
193-
'decl', # Node::xsub_decl object holding this XSUB declaration
193+
'decl', # Node::xsub_decl object holding this XSUB's declaration
194194

195195
# Boolean flags: they indicate that at least one of each specified
196-
# keywords has # been seen in this XSUB
196+
# keyword has been seen in this XSUB
197197
'seen_ALIAS',
198198
'seen_INTERFACE',
199199
'seen_INTERFACE_MACRO',
@@ -214,21 +214,20 @@ BEGIN { $build_subclass->('', # parent
214214
#
215215
# CODE_sets_ST0 is a flag indicating that something within a CODE
216216
# block is doing 'ST(0) = ..' or similar. This is a workaround for
217-
# a bug. See the code comments "Horrible 'void' return arg count hack"
217+
# a bug: see the code comments "Horrible 'void' return arg count hack"
218218
# in Node::CODE::parse() for more details.
219219
'CODE_sets_ST0', # Bool
220220
'XSRETURN_count_basic', # Int
221221
'XSRETURN_count_extra', # Int
222222

223-
# these maintain the alias parsing state across potentially multiple
223+
# These maintain the alias parsing state across potentially multiple
224224
# ALIAS keywords and or lines:
225225

226226
'map_alias_name_to_value', # Hash: maps seen alias names to their value
227227

228-
# Hash of hash of bools:
228+
'map_alias_value_to_name_seen_hash', # Hash of hash of bools:
229229
# indicates which alias names have been
230230
# used for each value.
231-
'map_alias_value_to_name_seen_hash',
232231

233232
'alias_clash_hinted', # Bool: an ALIAS warn-hint has been emitted.
234233

@@ -239,10 +238,12 @@ BEGIN { $build_subclass->('', # parent
239238
# name, map the short (PREFIX removed) name
240239
# to the original name.
241240

241+
# Maintain the ATTRS parsing state across potentially multiple
242+
# ATTRS keywords and or lines:
243+
242244
'attributes', # Array of strings: all ATTRIBUTE keywords
243245
# (possibly multiple space-separated
244246
# keywords per string).
245-
246247
)};
247248

248249

@@ -545,7 +546,7 @@ sub boot_code {
545546
| cv = $newXS(\"$xname\", XS_$cname$file_arg$proto_arg);
546547
| XSANY.any_i32 = $value;
547548
EOF
548-
$pxs->{need_boot_cv} = 1;
549+
$pxs->{need_boot_cv} = 1;
549550
}
550551
}
551552
elsif ($pxs->{cur_xsub}{attributes}) {
@@ -556,7 +557,7 @@ EOF
556557
| cv = $newXS(\"$pname\", XS_$cname$file_arg$proto_arg);
557558
| apply_attrs_string("$pxs->{PACKAGE_name}", cv, "$attrs", 0);
558559
EOF
559-
$pxs->{need_boot_cv} = 1;
560+
$pxs->{need_boot_cv} = 1;
560561
}
561562
elsif ( $self->{seen_INTERFACE}
562563
or $self->{seen_INTERFACE_MACRO})

0 commit comments

Comments
 (0)