Time::HiRes::sleep: use (;$) prototype, like CORE::sleep

Time::HiRes::sleep is supposed to be a drop-in replacement for
CORE::sleep, but before this patch Time::HiRes::sleep had no prototype,
leading to the following incompatibilities:

    CORE::sleep(1, "foo", "bar");  # syntax error
    Time::HiRes::sleep(1, "foo", "bar");  # OK, ignores all but 1st argument

    my @t = 42;
    CORE::sleep @t;  # sleeps for one second (number of elements in @t)
    Time::HiRes::sleep @t;  # sleeps for 42 seconds (@t in list context)

    CORE::sleep 1, next if $foo;
    # if $foo, then sleep for one second and start next loop iteration

    Time::HiRes::sleep 1, next if $foo;
    # parses as: Time::HiRes::sleep(1, next) if $foo;
    # if $foo, then start next loop iteration; no delay

Fixes #23628.

Author: mauke

dist/Time-HiRes/Changes

@@ -19,6 +19,7 @@ Revision history for the Perl extension Time::HiRes.
    build failures with MSVC.
  - don't try to suppress C++ compatibility warnings in C++ builds, since
    that warns.
+ - Fix sleep's prototype to match CORE::sleep (;$).
 
 1.9764 [2020-08-10]
  - Fix a bunch of repeated-word typos

dist/Time-HiRes/HiRes.pm

@@ -50,7 +50,7 @@ our @EXPORT_OK = qw (usleep sleep ualarm alarm gettimeofday time tv_interval
                  stat lstat utime
                 );
 
-our $VERSION = '1.9778';
+our $VERSION = '1.9779';
 our $XS_VERSION = $VERSION;
 $VERSION = eval $VERSION;
 

dist/Time-HiRes/HiRes.xs

@@ -1019,6 +1019,7 @@ nanosleep(nsec)
 
 NV
 sleep(...)
+PROTOTYPE: ;$
     PREINIT:
         struct timeval Ta, Tb;
     CODE:

dist/Time-HiRes/t/alarm.t

@@ -11,9 +11,9 @@ use Config;
 my $limit = 0.25; # 25% is acceptable slosh for testing timers
 
 my $xdefine = '';
-if (open(XDEFINE, "<", "xdefine")) {
-    chomp($xdefine = <XDEFINE> || "");
-    close(XDEFINE);
+if (open(my $fh, "<", "xdefine")) {
+    chomp($xdefine = <$fh> || "");
+    close($fh);
 }
 
 my $can_subsecond_alarm =
@@ -224,5 +224,3 @@ SKIP: {
         ok $got == 0 or print("# $got\n");
     }
 }
-
-1;

dist/Time-HiRes/t/sleep.t

@@ -1,17 +1,27 @@
 use strict;
 
-use Test::More tests => 4;
+use Test::More tests => 5;
 BEGIN { push @INC, '.' }
 use t::Watchdog;
 
 BEGIN { require_ok "Time::HiRes"; }
 
 use Config;
 
+SKIP: {
+    skip "no hi-res sleep", 1 unless defined &Time::HiRes::sleep;
+    is prototype(\&Time::HiRes::sleep), prototype('CORE::sleep'),
+        "Time::HiRes::sleep's prototype matches CORE::sleep's";
+}
+
+eval { Time::HiRes::sleep(-1) };
+like $@, qr/::sleep\(-1\): negative time not invented yet/,
+        "negative time error";
+
 my $xdefine = '';
-if (open(XDEFINE, "<", "xdefine")) {
-    chomp($xdefine = <XDEFINE> || "");
-    close(XDEFINE);
+if (open(my $fh, "<", "xdefine")) {
+    chomp($xdefine = <$fh> || "");
+    close($fh);
 }
 
 my $can_subsecond_alarm =
@@ -20,10 +30,6 @@ my $can_subsecond_alarm =
    defined &Time::HiRes::usleep &&
    ($Config{d_ualarm} || $xdefine =~ /-DHAS_UALARM/);
 
-eval { Time::HiRes::sleep(-1) };
-like $@, qr/::sleep\(-1\): negative time not invented yet/,
-        "negative time error";
-
 SKIP: {
     skip "no subsecond alarm", 2 unless $can_subsecond_alarm;
     my $f = Time::HiRes::time;
@@ -35,5 +41,3 @@ SKIP: {
     printf("# sleep...%s\n", Time::HiRes::tv_interval($r));
     ok 1;
 }
-
-1;

dist/Time-HiRes/t/time.t

@@ -1,11 +1,17 @@
 use strict;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
 BEGIN { push @INC, '.' }
 use t::Watchdog;
 
 BEGIN { require_ok "Time::HiRes"; }
 
+SKIP: {
+    skip "no hi-res time", 1 unless defined &Time::HiRes::time;
+    is prototype(\&Time::HiRes::time), prototype('CORE::time'),
+        "Time::HiRes::time's prototype matches CORE::time's";
+}
+
 SKIP: {
     skip "no gettimeofday", 1 unless &Time::HiRes::d_gettimeofday;
     my ($s, $n, $i) = (0);
@@ -20,5 +26,3 @@ SKIP: {
         or print("# Time::HiRes::time() not close to CORE::time()\n");
     printf("# s = $s, n = $n, s/n = %s\n", abs($s)/$n);
 }
-
-1;