Skip to content

Commit cf50778

Browse files
committed
allocmy: minor clean-up
- Remove redundant casts. - Format 'if (' consistently with a space everywhere. - Fix typo in comment.
1 parent 9fb169d commit cf50778

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

op.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -770,11 +770,10 @@ Perl_allocmy(pTHX_ const char *const name, const STRLEN len, const U32 flags)
770770
assert(name[0] && name[1]);
771771

772772
if (flags & ~SVf_UTF8)
773-
croak("panic: allocmy illegal flag bits 0x%" UVxf,
774-
(UV)flags);
773+
croak("panic: allocmy illegal flag bits 0x%" U32xf, flags);
775774

776775
is_idfirst = flags & SVf_UTF8
777-
? isIDFIRST_utf8_safe((U8*)name + 1, name + len)
776+
? isIDFIRST_utf8_safe(name + 1, name + len)
778777
: isIDFIRST_A(name[1]);
779778

780779
/* $_, @_, etc. */
@@ -804,11 +803,11 @@ Perl_allocmy(pTHX_ const char *const name, const STRLEN len, const U32 flags)
804803
/* allocate a spare slot and store the name in that slot */
805804

806805
U32 addflags = 0;
807-
if(is_our)
806+
if (is_our)
808807
addflags |= padadd_OUR;
809-
else if(PL_parser->in_my == KEY_state)
808+
else if (PL_parser->in_my == KEY_state)
810809
addflags |= padadd_STATE;
811-
else if(PL_parser->in_my == KEY_field)
810+
else if (PL_parser->in_my == KEY_field)
812811
addflags |= padadd_FIELD;
813812

814813
off = pad_add_name_pvn(name, len, addflags,
@@ -821,7 +820,7 @@ Perl_allocmy(pTHX_ const char *const name, const STRLEN len, const U32 flags)
821820
: NULL
822821
)
823822
);
824-
/* anon sub prototypes contains state vars should always be cloned,
823+
/* anon sub prototypes containing state vars should always be cloned,
825824
* otherwise the state var would be shared between anon subs */
826825

827826
if (PL_parser->in_my == KEY_state && CvANON(PL_compcv))

0 commit comments

Comments
 (0)