Move Perl_newSUB() from mathoms to macro in op.h

Author: khwilliamson

embed.fnc

@@ -2148,7 +2148,7 @@ ARdp	|OP *	|newASSIGNOP	|I32 flags				\
 				|NULLOK OP *left			\
 				|I32 optype				\
 				|NULLOK OP *right
-Adm	|CV *	|newATTRSUB	|I32 floor				\
+Admp	|CV *	|newATTRSUB	|I32 floor				\
 				|NULLOK OP *o				\
 				|NULLOK OP *proto			\
 				|NULLOK OP *attrs			\
@@ -2275,7 +2275,7 @@ ARdp	|OP *	|newSTATEOP	|I32 flags				\
 				|NULLOK OP *o
 p	|CV *	|newSTUB	|NN GV *gv				\
 				|bool fake
-AMbdp	|CV *	|newSUB 	|I32 floor				\
+Admp	|CV *	|newSUB 	|I32 floor				\
 				|NULLOK OP *o				\
 				|NULLOK OP *proto			\
 				|NULLOK OP *block

embed.h

@@ -405,6 +405,7 @@
 # define newANONSUB(a,b,c)                      Perl_newANONSUB(aTHX_ a,b,c)
 # define newARGDEFELEMOP(a,b,c)                 Perl_newARGDEFELEMOP(aTHX_ a,b,c)
 # define newASSIGNOP(a,b,c,d)                   Perl_newASSIGNOP(aTHX_ a,b,c,d)
+# define newATTRSUB(a,b,c,d,e)                  Perl_newATTRSUB(aTHX,a,b,c,d,e)
 # define newAV()                                Perl_newAV(aTHX)
 # define newAVREF(a)                            Perl_newAVREF(aTHX_ a)
 # define newAVav(a)                             Perl_newAVav(aTHX_ a)
@@ -447,6 +448,7 @@
 # define newRV_noinc(a)                         Perl_newRV_noinc(aTHX_ a)
 # define newSLICEOP(a,b,c)                      Perl_newSLICEOP(aTHX_ a,b,c)
 # define newSTATEOP(a,b,c)                      Perl_newSTATEOP(aTHX_ a,b,c)
+# define newSUB(a,b,c,d)                        Perl_newSUB(aTHX,a,b,c,d)
 # define newSV(a)                               Perl_newSV(aTHX_ a)
 # define newSVOP(a,b,c)                         Perl_newSVOP(aTHX_ a,b,c)
 # define newSVREF(a)                            Perl_newSVREF(aTHX_ a)

mathoms.c

@@ -147,13 +147,6 @@ Perl_my_lstat(pTHX)
     return my_lstat_flags(SV_GMAGIC);
 }
 
-CV *
-Perl_newSUB(pTHX_ I32 floor, OP *o, OP *proto, OP *block)
-{
-    return newATTRSUB(floor, o, proto, NULL, block);
-}
-
-
 STRLEN
 Perl_is_utf8_char_buf(const U8 *buf, const U8* buf_end)
 {

op.h

@@ -1096,8 +1096,10 @@ C<sib> is non-null. For a higher-level interface, see C<L</op_sibling_splice>>.
 #  define OP_SIBLING(o)		OpSIBLING(o)
 #endif
 
-#define newATTRSUB(f, o, p, a, b) Perl_newATTRSUB_x(aTHX_  f, o, p, a, b, FALSE)
-#define newSUB(f, o, p, b)	newATTRSUB((f), (o), (p), NULL, (b))
+#define Perl_newATTRSUB(mTHX, f, o, p, a, b)                            \
+        Perl_newATTRSUB_x(aTHX_  f, o, p, a, b, FALSE)
+#define Perl_newSUB(mTHX, f, o, p, b)	                                \
+        Perl_newATTRSUB(aTHX, (f), (o), (p), NULL, (b))
 
 #ifdef USE_ITHREADS
 #  define OP_CHECK_MUTEX_INIT		MUTEX_INIT(&PL_check_mutex)