regen/embed.pl: Skip unnecessary code

khwilliamson · khwilliamson · commit ee8c0b0c125e · 2025-08-04T07:10:44.000-06:00
If an argument is a literal string, it's not going to be anything else,
so convert an elsif to and else.
diff --git a/regen/embed.pl b/regen/embed.pl
@@ -245,7 +245,8 @@ sub generate_proto_h {
                     die_at_end 'm flag required for "literal" argument'
                                                             unless $has_mflag;
                 }
-                elsif (   $args_assert_line
+                else {
+                   if (   $args_assert_line
                        && $arg =~ /\*/
                        && $arg !~ /\b(NN|NULLOK)\b/ )
                 {
@@ -289,6 +290,7 @@ sub generate_proto_h {
                         push @asserts, "assert($type_assert)";
                     }
                 }
+                }
             }
             $ret .= join ", ", @$args;
         }

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,8 @@ sub generate_proto_h {`
`245`	`245`	`die_at_end 'm flag required for "literal" argument'`
`246`	`246`	`unless $has_mflag;`
`247`	`247`	`}`
`248`		`- elsif ( $args_assert_line`
	`248`	`+ else {`
	`249`	`+ if ( $args_assert_line`
`249`	`250`	`&& $arg =~ /\*/`
`250`	`251`	`&& $arg !~ /\b(NN\|NULLOK)\b/ )`
`251`	`252`	`{`
`@@ -289,6 +290,7 @@ sub generate_proto_h {`
`289`	`290`	`push @asserts, "assert($type_assert)";`
`290`	`291`	`}`
`291`	`292`	`}`
	`293`	`+ }`
`292`	`294`	`}`
`293`	`295`	`$ret .= join ", ", @$args;`
`294`	`296`	`}`